search

cellannotation / cell-annotation-schema

General, open-standard schema for cell annotations
11 stars 2 forks source link

support +&- evidence markers #66

Closed dosumis closed 8 months ago

dosumis commented 10 months ago

Fixes #32

@mfutey @evanbiederstedt - would be good to add this as we have examples to support for Siletti. Can hold off until you agree on matching update to CAP AnnData spec.

github-actions[bot] commented 10 months ago

Validation Passes.

dosumis commented 8 months ago

Neither field is mandatory. I think I'd rather be explicit in naming and use 'positive marker genes' - although this will cause some backwards compatibility issues.

evanbiederstedt commented 8 months ago

"marker genes" is mandatory for CAP

Therefore, I'd prefer that "positive and negative" are only used explicitly if it's relevant for the project. In this case, the positive markers could be listed in "marker genes"

dosumis commented 8 months ago

marker genes" is mandatory for CAP

Therefore, I'd prefer that "positive and negative" are only used explicitly if it's relevant for the project. In this case, the positive markers could be listed in "marker genes"

OK. I'll go with that then.

github-actions[bot] commented 8 months ago

Validation Passes.

dosumis commented 8 months ago

Fixed. Please check and approve if now OK. Ta