search

cellarium-ai / cellarium-ml

Distributed single-cell data analysis.
BSD 3-Clause "New" or "Revised" License
11 stars 2 forks source link

AnnDataSchema validate_anndata fix #180

Closed sjfleming closed 4 months ago

sjfleming commented 4 months ago

Closes #179

There was a problem with categoricals in obs where dataframe.dtypes.equals(dataframe2.dtypes) would say False even when it wasn't.

This solution looks uglier for sure, but I tried to include some helpful error messages for debugging.

sjfleming commented 4 months ago

It seems I may have misjudged the problem, see comments on #179

sjfleming commented 4 months ago

I did like the error message detail included here though. Maybe I'll make a separate PR that doesn't change the validation but just gives some more detailed error messages.

ordabayevy commented 4 months ago

More detailed error message would be great!