search

cellengine / cellengine-python-toolkit

CellEngine Python API toolkit
https://cellengine.github.io/cellengine-python-toolkit/
MIT License
4 stars 0 forks source link

Special comp types are not handled correctly for `experiment.activeCompensation` #146

Closed zbjornson closed 2 years ago

zbjornson commented 2 years ago

I haven't tested this to confirm, but from read the code, we don't correctly handle the special comp types.

https://github.com/primitybio/cellengine-python-toolkit/blob/1f9dd168f1f27e2beba69f02e340371190857b33/cellengine/resources/experiment.py#L211-L233

The setter will set "UNCOMPENSATED" and friends as _active_comp, and the getter tries to retrieve the comp by ID if it's a string.

We also need to provide an enum/constants for UNGATED, FILE_INTERNAL and PER_FILE.