cellgeni / sceasy

A package to help convert different single-cell data formats to each other
GNU General Public License v3.0
346 stars 52 forks source link

Converting SCE to LOOM obs and var attribute names #59

Open SimonDMurray opened 1 year ago

SimonDMurray commented 1 year ago

Hi, I was recently trying to convert an SCE object to loom and I noticed the sce2loom function contains the line: colnames_attr = "obs_names", rownames_attr = "var_names" which I changed to: colnames_attr = "CellID", rownames_attr = "Gene" in order to get my downstream analysis to work.

I was curious if there was a reason you did this as LOOM documentation suggests "CellID" and "Gene"?

Thanks in advance! Simon

nh3 commented 1 year ago

Sorry for the late reply. Thank you for bringing this to attention. It was an outdated decision/piece of code. Happy to change to "CellID" and "Gene" in the next release. A PR would be highly welcome. :)