search

cellml / libcellml

Repository for libCellML development.
https://libcellml.org
Apache License 2.0
16 stars 21 forks source link

Keep Python generated wrappers at SWIG version 4.0.1 #1063

Closed hsorby closed 1 year ago

hsorby commented 1 year ago

Fixes #1062.

agarny commented 1 year ago

I haven't checked in details, but it looks like this PR is aiming at supporting old versions of SWIG. I really don't see the point. Let's be honest, we are likely going to be the only ones ever to build libCellML's Python bindings. So, let's try to make our life as easy as possible rather than unnecessarily complicated. IOW, let's just make the minimum version of SWIG be 4.1.0.

hsorby commented 1 year ago

I agree, but the sticking point here is Ubuntu. Ubuntu doesn't have SWIG 4.1.0 available through the package manager and I prefer not to make people install packages that aren't available over adjusting for small changes like this one in the codebase.

agarny commented 1 year ago

People? Which people? Me and you, most likely? As for Ubuntu not having that package, we can simply build the version of SWIG we want and use that. After all, this is what we do with libxml2 on Windows, no? So, why would we make our life unnecessarily difficult with SWIG, knowing that people interested in the Python bindings will just wait for us to push things on PyPI rather than going through the trouble of building things themselves.