search

cellml / libcellml

Repository for libCellML development.
https://libcellml.org
Apache License 2.0
16 stars 21 forks source link

Analyser: allow for the unknown variable to be either on the LHS or RHS of an equation #1071

Closed agarny closed 1 year ago

agarny commented 1 year ago

Fixes #1070 (relies on PR #1069).

agarny commented 1 year ago

@hsorby, any idea of why the Python coverage are now failing? Otherwise, I assume that all the conversations can be resolved so as not to unnecessarily clutter this PR?

hsorby commented 1 year ago

It is the flaky CI machines that we are now using, I have triggered it again and now showing a proper run.

agarny commented 1 year ago

I thought we had a dodgy hard drive but that it had been replaced? So, what is playing up now?

hsorby commented 1 year ago

No, not replaced. We/I need to ask IT to upgrade to the pro-plan for our virtual machines. I haven't gotten around to this yet.

agarny commented 1 year ago

seems like we should have tests with a mix, right? just in case...

Sure, happy to mix things using, say, the HH52 model. Will do that tomorrow.

agarny commented 1 year ago

seems like we should have tests with a mix, right? just in case...

See 8fedc7f9.

agarny commented 1 year ago

great that re-arranging equations in the HH model results in the same generated code :)

Yes, phew! :)