search

cellml / libcellml

Repository for libCellML development.
https://libcellml.org
Apache License 2.0
16 stars 21 forks source link

Fix an issue when initialising a state variable using a variable instead of a constant #1147

Closed agarny closed 1 year ago

agarny commented 1 year ago

Fixes #1144.

agarny commented 1 year ago

My first comment would be is this a minimal example that illustrates the issue? It seems to me to be a model that highlights the bug in question.

It is indeed. I just went for the model given to us by @WeiweiAi in issue #1144. I am happy to simplify it, if really needed.

hsorby commented 1 year ago

I think this full model should be added to tutorials or as an end-to-end test. These tests are unit tests, that is, trying to put the minimal groundwork in place to illustrate a particular issue. I am in favour of reducing the model to the bare minimum required to create the failing situation.

agarny commented 1 year ago

Ok, now using a minimal model.