cellml / libcellml

Repository for libCellML development.
https://libcellml.org
Apache License 2.0
17 stars 21 forks source link

Annotator assignAllIds misleading #1150

Closed hsorby closed 1 year ago

hsorby commented 1 year ago

The documentation for the Annotator assignAllIds method is erroneous. The return value does not indicate if the model has been modified. The code itself for assignAllIds is, how to say, less than the desired standard.

The first question is, do we want the method to do what the method documentation states? The second question, do we want to refactor the method as part of this issue?