search

cellml / libcellml

Repository for libCellML development.
https://libcellml.org
Apache License 2.0
17 stars 21 forks source link

Parser: false negative regarding encapsulation #377

Open agarny opened 5 years ago

agarny commented 5 years ago

If you try to parse this model, libCellML will then report the following error:

Encapsulation in model 'my_model' specifies 'circle_y_implementation' as a component in a component_ref but it does not exist in the model.

However, as far as I can tell, everything is fine with that model. (I use it as one of my tests for code generation, and if I ignore the parsing error then everything is fine.)

Also, I am not sure that someone who doesn't know anything about CellML would understand the above error message.

nickerso commented 5 years ago

I agree that the model looks fine and I also can't spot any error.

The error messages are aimed at libcellml users, who would presumably know something about CellML. But good to keep issues distinct.

kerimoyle commented 5 years ago

... all the error messages need some understanding of CellML :) We can work on friendlier ones which reference a more human-readable document when the Issues stuff is more progressed.

On Wed, 10 Jul 2019 at 02:45, David Nickerson notifications@github.com wrote:

I agree that the model looks fine and I also can't spot any error.

The error messages are aimed at libcellml users, who would presumably know something about CellML. But good to keep issues distinct.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cellml/libcellml/issues/377?email_source=notifications&email_token=ALFXCNBSM2PLMEKE4OSEKBLP6UWKRA5CNFSM4H7KE4X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZR6HVY#issuecomment-509862871, or mute the thread https://github.com/notifications/unsubscribe-auth/ALFXCNHW377MF4ZKRZQKSQTP6UWKRANCNFSM4H7KE4XQ .