Should prevent the build from going ahead if we don't have `zlib`

cellml / libcellml

Repository for libCellML development.

https://libcellml.org

Apache License 2.0

17 stars 21 forks source link

Should prevent the build from going ahead if we don't have `zlib` #925

Open agarny opened 3 years ago

agarny commented 3 years ago

I am trying to build libCellML on a "vanilla" version of Windows and, after installing libXml2, CMake allows me to fully configure libCellML (even though I don't have zlib on my system). This means that when I try to build libCellML, I eventually get told that zlib.h cannot be found (from xmldoc.cpp).

hsorby commented 3 years ago

Just how I planned it. Did you follow the build instructions?

agarny commented 3 years ago

You mean https://libcellml.org/documentation/developers/v0.2.0/dev_setup#dev-setup?

hsorby commented 3 years ago

I guess they need updating then.

agarny commented 3 years ago

Yup! :)

nickerso commented 3 years ago

If I remember, this was something that changed with using the pre-built libXml2 with (updated) VS 2019. @hsorby fixed it on my machine and then was presumably going to update the instructions ;-) It looks like I built my own libxml2 and zlib from the OpenCMISS-Dependencies sources.