search

cellml / libcellml

Repository for libCellML development.
https://libcellml.org
Apache License 2.0
16 stars 21 forks source link

CMake: LLVM coverage should require unit tests #956

Open agarny opened 3 years ago

agarny commented 3 years ago

As for coverage and memcheck, LLVM coverage should require unit tests to be enabled.

hsorby commented 3 years ago

I would have though that we should not make coverage and memcheck require unit tests. These settings don't require unit tests it is just convenient that they do from a CI perspective.

Either way, we should at least be consistent. We don't want to show bias against LLVM.