Adjusting section 0 header display and adding new option.

cellule-tice / moodle-format_collapsibletopics

Clone of core topics format that adds collapsing behaviour to sections.

7 stars 6 forks source link

Adjusting section 0 header display and adding new option. #11

Closed rboyatt closed 5 years ago

rboyatt commented 5 years ago

This pull request adjusts the behaviour of the course format so the visibility of section 0 header is consistent with topics format. This is intended to fix #1

It also adds an option to show/hide the section 0 header.

Interesting in others testing that the behaviour is consistent with topics format, and if the additional option is necessary.

jrm-unamur commented 5 years ago

Hi, First of all thanks for your work. Unfortunately, I cannot accept it as is for the following reasons

your section0-visibility branch is not based on the last version of the plugin
travis checks failed (1 codechecker error "True" instead of "true") and many errors in phpunit tests and behat tests because your new course format option is not handled in these) You can see details here

So I'm closing this pull request. Feel free to submit another one when errors are fixed

Kind regards