cellule-tice / moodle-format_collapsibletopics

Clone of core topics format that adds collapsing behaviour to sections.
7 stars 6 forks source link

Restricting access to a topic completely hides it from students despite eye icon not being crossed #5

Closed pkgh closed 5 years ago

pkgh commented 6 years ago

Scenario:

  1. Add e.g. a group based restriction to a topic.
  2. Keep the eye open, which should keep the section title visible to students in greyed-out format (cf. core Topics / Weekly format) Cf screenshot 2018-11-04 22_15_36 - edit 4 final test - mozilla firefox

Unfortunately in the Collapsible Topics (as well as Collapsible Weeks) format, setting a section like this completely removes the topic from the Student's course page - which should ONLY happen if that restrict access eye is closed, i.e. has a line running through it. This is a major weakness of this otherwise very useful & clean course format.

jrm-unamur commented 6 years ago

Hi pkgh, Sorry for late answer, I'm only noticing your post now ... Can you tell me your moodle version and theme (+version) used so that I can replicate the problem that doesn't happen with my boost child theme

pkgh commented 6 years ago

Hi,

Collapsible Topics: 1.1-stable 2018061400

Moodle: 3.5.2 (Build: 20180910) (My production site, which I cannot upgrade most likely until the summer. Have NOT tested higher than that so far.)

Theme: Boost

Thanks!

jrm-unamur commented 6 years ago

Hi, I think the issue is fixed on branch "issue5". Have you got a test instance to try it directly from that branch, so that you can validate before I merge it into master. If everything works ok for you, I will make necessary modifications into collapsibleweeks as well and release a new version asap (maybe I'll try to address some other issues before that) Thanks

pkgh commented 6 years ago

Hi, The fix appears to work OK :) . Just tried it on my test Moodle 3.5.2 site. Yes, porting the patch to the Collapsible Weeks format is what we want now :). Looking forward to that and to the official release. Thanks!

jrm-unamur commented 5 years ago

Update released! Closing Cheers