celluloid-player / celluloid

A simple GTK+ frontend for mpv
https://celluloid-player.github.io
GNU General Public License v3.0
1.1k stars 87 forks source link

Make playlist part of the video? #692

Open francoism90 opened 2 years ago

francoism90 commented 2 years ago

Overview Description: When you open the playlist, the player seems to attach itself to the window instead of the (inner) playing video.

This works fine when using Celluloid maximized, however when you snap the player to a side of the screen and toggle the playlist, it does show the playlist off-screen and/or overlaps the window next to it.

Steps to Reproduce:

  1. Open Celluloid and play a video
  2. Snap Celluloid to the left/right and snap/place another window on the other side
  3. Toggle Playlist

Actual Results: The playlist overlaps other windows or simple goes off-screen when snapped on the right side.

Expected Results: Open the playlist in the video itself, making the current playing source smaller.

Version: git

Additional Information: Arch Linux

gnome-mpv commented 2 years ago

It already works that way for me on GNOME 40; showing the playlist while the window is snapped shrinks the video instead of expanding the window.

What WM/DE are you using?

francoism90 commented 2 years ago

@gnome-mpv I'm using an tiling extension with gaps, that's why it didn't work for me when being snapped. :)

However would it be possible to always shrink the video, even when not being snapped? If I toggle the playlist it mostly shows off-screen for me when playing video's with a high resolution.

gnome-mpv commented 2 years ago

However would it be possible to always shrink the video, even when not being snapped? If I toggle the playlist it mostly shows off-screen for me when playing video's with a high resolution.

Sure. That could be made an option.

francoism90 commented 2 years ago

@gnome-mpv Thanks for looking into it! :)

jannuary commented 1 month ago

I did this: Screenshot from 2024-06-10 12-36-53

The question is, whether it should ever resize the window, or if it should keep the window size the same, while showing the playlist in a sidebar and shrinking the video, or have an overlay sidebar (outside of fullscreen, which will always have an overlay sidebar)

I'm more inclined to say it should not resize the window ever, since it's very much unusual and unexpected behaviour

gnome-mpv commented 1 month ago

The question is, whether it should ever resize the window, or if it should keep the window size the same, while showing the playlist in a sidebar and shrinking the video, or have an overlay sidebar (outside of fullscreen, which will always have an overlay sidebar)

I think we should do an overlay sidebar. I think that will fit better with the current floating widgets than the alternatives.

I'm more inclined to say it should not resize the window ever, since it's very much unusual and unexpected behaviour

I agree. I initially had the playlist resize the window because you can toggle it without moving or resizing the video that way, but that's an unusual behavior as you said and the extra complexity probably isn't worth it.

jannuary commented 1 month ago

I think we should do an overlay sidebar.

Ask and you shall recieve: image

gnome-mpv commented 1 month ago

Ask and you shall recieve:

Thanks! I think that looks awesome.