celluloid-player / celluloid

A simple GTK+ frontend for mpv
https://celluloid-player.github.io
GNU General Public License v3.0
1.16k stars 92 forks source link

Thick square border around window + full screen & black borders around menus #729

Open hyuri opened 2 years ago

hyuri commented 2 years ago

Overview There is a thick square (no rounded corners) border around the main window, and also when I go into full screen (which gets in the way of the video). There is also a much thicker black border around menus -- perhaps a not-properly-drawn drop shadow or similar?

Clicking on one of the menus -- the hamburger menu, for example -- blocks keystrokes (I'll file a separate bug report for this), so I can't take a screenshot to show the even thicker black borders around the menus to post here.

System Info:

Steps to Reproduce:

  1. Install Celluloid via flatpak (in my case, I installed the flatpak via Pop!_Shop, Pop!_OS' app store);
  2. Open Celluloid;
  3. See thick square borders & thick black borders around menus.

Actual Results: Thick square border around window and in full screen. Thick black border around menus.

Expected Results: No thick borders around window or -- especially -- in full screen.

Version: 0.22

Additional Information: Windowed: image

Full Screen: image

gnome-mpv commented 2 years ago

I can't reproduce this in my Pop_OS! 21.10 VM. I tried following the steps you gave, but I don't see the borders like in your screenshots.

michaelBelsanti commented 2 years ago

I have the same border on Arch using Celluloid from the official repository version 0.22

Alessa-L commented 2 years ago

Using Arch, the solution i found was: Disable/Uncheck "Enable client-side decorations" which is found on "Preferences" in the "Interface" tab.

hyuri commented 2 years ago

Using Arch, the solution i found was: Disable/Uncheck "Enable client-side decorations" which is found on "Preferences" in the "Interface" tab.

Worked for me in Pop!_OS 21.10. Thanks!

michaelBelsanti commented 2 years ago

This should probably be disabled by default or the borders should be removed, I'm not sure many people would want to see them while fullscreened.

gnome-mpv commented 2 years ago

This should probably be disabled by default or the borders should be removed, I'm not sure many people would want to see them while fullscreened.

The borders are not being added by Celluloid. They show up on some WMs like Openbox and QTile, but I'm still not sure why.

hyuri commented 2 years ago

New info: The issue only appears when hardware acceleration is not available. And it happens to all LibAdwaita/GTK4 apps, not just Celluloid.

I have a weird setup where hardware acceleration is only available when I use either the Integrated(Intel) or Dedicated(Nvidia) GPU but not in Hybrid(both). When I boot into Hybrid mode, the issue appears, when I boot into Integrated or Nvidia, the issue is gone.

atticus-sullivan commented 2 years ago

Actual Results: Thick black border around menus.

Not quite sure if this is the same Issue, but at least I'd describe it similar (no images for the borders around menus).

Looks like this in my case: image Arc-Darker/Arc-Dark Theme image Adwaita Theme

As this issue occurred for me just after the switch from gtk3 to gtk4, I suspect there might be a relation to this. And in addition these borders are gone when starting a compositor in advance (but tbh I'd like to avoid having to run a compositor just because of this issue).

If this doesn't look like the same issue, just tell me and I'll open a new one ; )

I hope that these information can help in fixing this issue

Yonnji commented 10 months ago

Window borders can be removed with some css in the ~/.config/gtk-4.0/gtk.css file:

window.solid-csd {
  padding: 0px;
  border: none;
  box-shadow: none;
}

If you want to remove them only in fullscreen/maximized mode you can use window.solid-csd.maximized and window.solid-csd.fullscreen selectors instead or combine them as you want.