search

celluloid-player / celluloid

A simple GTK+ frontend for mpv
https://celluloid-player.github.io
GNU General Public License v3.0
1.15k stars 91 forks source link

Ability to have the playback toolbar permanently shown while in windowed mode #750

Open nekohayo opened 2 years ago

nekohayo commented 2 years ago

The preferences dialog has a "Use floating controls in windowed mode" option that is useless to me in its current form, because it needs to be always-on to even be able to use the app with the mouse; turning it off means the toolbar does not appear under any circumstances while in windowed mode.

Instead, what I would expect as behavior would be that when that option is turned off, the toolbar is shown "permanently" (at all times while in windowed mode). I would then expect that entering fullscreen mode would make the toolbar floating again.

The reason why I wish to have a perma-toolbar in windowed mode is that I very often use Celluloid as an audio/video player and reviewing tool. I use it to listen to voice mails, scrub quickly through an audio track with the mouse, or do timing analysis/scouting in videos (when reviewing a video for annotation/subtitling), so in all cases, particularly the last one, I need the seek bar to remain in place and I need to see the timecodes at all times, instead of having to wiggle the mouse all the time.

So even as part of an eventual global UI redesign in #696, please take into account the need for some users to be able to have permanent controls while in windowed mode.

Note: I would welcome those controls being part of the headerbar/CSDs if you wish to save space, instead of the current top+bottom layout.

gnome-mpv commented 2 years ago

The preferences dialog has a "Use floating controls in windowed mode" option that is useless to me in its current form, because it needs to be always-on to even be able to use the app with the mouse; turning it off means the toolbar does not appear under any circumstances while in windowed mode.

With the option off, does the toolbar show up if you press Ctrl+H?

nekohayo commented 2 years ago

Interesting! Yes it does. Apparently, io.github.celluloid-player.Celluloid.window-state's show-controls (from what I can see in dconf-editor now), must indeed have been "false" all this time... yet I do not recall ever using a keyboard shortcut such as Ctrl+H, and this is on multiple machines.

Could it be that this setting's default was incorrectly set in previous releases, and it didn't get autocorrected afterwards? Or what is the point of there being a setting for this to be toggled on and off when there is also an option for autohiding?

gnome-mpv commented 2 years ago

Could it be that this setting's default was incorrectly set in previous releases, and it didn't get autocorrected afterwards?

IIRC there was a bug with floating controls that causes show-controls to be set to false if the player is closed while the controls are still hidden. That could be the reason.

Or what is the point of there being a setting for this to be toggled on and off when there is also an option for autohiding?

It was a requested feature, but the implementation could definitely be improved. Maybe the controls should only be allowed to be hidden this way if floating controls is disabled.