search

celluloid-player / celluloid

A simple GTK+ frontend for mpv
https://celluloid-player.github.io
GNU General Public License v3.0
1.1k stars 87 forks source link

Celluloid 0.23 GTK Theme issues #777

Open BaronKrause opened 2 years ago

BaronKrause commented 2 years ago

Using Pop OS (20.04-22.04) Ive noticed that the PPA version of Celluloid that is always kept current has some issues with the GTK theming that isn't present in the default repo version (0.20).

The minimize and close buttons don't seem to theme properly, on the Pop theme they seem to still use the same color for the buttons as the rest of the title bar, but there is a thin outline of the color it should of been, like Celluloid is rendering a gray minimize and close button over the orange ones from the GTK theme: Screenshot from 2022-05-17 11-24-38

How it looks in the distro 0.20 version that's consistent with the rest of the themed applications: Screenshot from 2022-05-17 11-31-02

A similar issue happens with the Dracula theme, except there it seems to make the buttons solid colors without the symbols, but the symbols appear when hovering over

The other issue is with the dark mode setting, it seems to just use Adwaita-dark no mater what when selected. 0.20 from the stock repo would use the dark variant of whatever theme you were using, or at the very least recognizes the distros Pop-dark and Pop-light theme and would use the dark variant if selected if you happen to be using the light variant for everything else.

gnome-mpv commented 2 years ago

If the PPA version is new enough to use libadwaita, then you probably need to set the theme using the GTK_THEME envvar.

BaronKrause commented 2 years ago

If the PPA version is new enough to use libadwaita, then you probably need to set the theme using the GTK_THEME envvar.

I just tested that and all it seems to do is override the theme in celluloid completely, making it ignore that "Enable dark theme" checkbox entirely.

So 0.20 would use your system theme without that checkbox, and the dark variant of it if checked (making it the same for both if you were using the dark version as your system theme) and 0.23 would use your system theme without the checkbox and force dark Adwaita with the checkbox.

With that envvar it just uses whatever you et it to for both and ignores the checkbox.

Both with and without the envvar set it doesn't seem to be working correctly (and the pictured issue with the minimize and close buttons didn't change with setting the envvar)

hazelnot commented 1 year ago

Not sure if it's a related issue, but I'm using Celluloid 0.23, which I assume should be using libadwaita, but somehow ends up using the old Adwaita even though I even set the legacy theme to a libadwaita lookalike from Gnome Tweaks