search

celluloid-player / celluloid

A simple GTK+ frontend for mpv
https://celluloid-player.github.io
GNU General Public License v3.0
1.16k stars 92 forks source link

Remember playback state and window size when reseting mpv #956

Open jannuary opened 5 months ago

jannuary commented 5 months ago

Overview Description: When closing the preferences window, Celluloid changes its window size and rewinds to some other point

Steps to Reproduce:

  1. Watch or seek a video to a certain point
  2. Fullscreen or maximise the window
  3. Enter and leave preferences

Actual Results: The window unmaximises and the video gets rewinded to an earlier point. Expected Results: Quiting preferences doesn't change the window size or playback state.

Version: 0.26

gnome-mpv commented 5 months ago

Should be fixed in the git version.

I'll make a new release soon.

jannuary commented 5 months ago

Window state is still getting reset on mainline, though unsure about playback since that doesn't seem consistently reproducable.

Or not? Doesn't seem to be a problem now? Odd.

gnome-mpv commented 5 months ago

Or not? Doesn't seem to be a problem now? Odd.

Did you change any settings when that happened? Some settings change require an mpv reset to work reliably, so if any of those are changed (e.g. anything involving external mpv config files), both playback and window state will still get reset. Just opening/closing the prefs dialog shouldn't do anything though.

jannuary commented 5 months ago

Ah, that must be it — changing the configs still unfullscreens the app. That said, it probably shouldn't jump around in any case :)