search

celluloid-player / celluloid

A simple GTK+ frontend for mpv
https://celluloid-player.github.io
GNU General Public License v3.0
1.13k stars 88 forks source link

HDR playback is not supported. #964

Open Weather-OS opened 2 months ago

Weather-OS commented 2 months ago

Overview Description: Whilst this project uses the MPV project as it's video player backend, it doesn't support HDR playback.

Steps to Reproduce:

  1. Add the options --vo=gpu-next --target-colorspace-hint=yes --gpu-api=vulkan --gpu-context=waylandvk as you normally would in MPV inside "Extra MPV Options".
  2. Play an HDR video.

Actual Results: HDR doesn't get activated.

Expected Results: HDR should get detected and activated.

Version: 0.27-1

jannuary commented 2 months ago

I don't think GTK supports HDR at the moment, and it would have to be landed there before we'll be able to implement it.

Weather-OS commented 2 weeks ago

Looks like it's shipping in 4.16. Any plans on implementing it? https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7444 https://docs.gtk.org/gdk4/struct.ColorState.html https://blog.gtk.org/2024/08/11/the-colors-of-gtk/

gnome-mpv commented 2 weeks ago

Looks like it's shipping in 4.16. Any plans on implementing it?

Sure, but I would wait until it's actually released.

Weather-OS commented 1 week ago

It's out. https://gitlab.gnome.org/GNOME/gtk/-/tags/4.16.0