search

celluloid / celluloid-io

UNMAINTAINED: See celluloid/celluloid#779 - Evented sockets for Celluloid actors
https://celluloid.io
MIT License
879 stars 93 forks source link

Avoid SSLSocket leaks by setting sync_close by default #135

Closed zanker closed 9 years ago

zanker commented 9 years ago

@tarcieri

tarcieri commented 9 years ago

Oh my, the build failures :cry:

They all seem unrelated at least, but...

/cc @digitalextremist

digitalextremist commented 9 years ago

Uhhh. #134?

digitalextremist commented 9 years ago

Yeah. These are rspec syntax/behavior failures.

zanker commented 9 years ago

Sorry, not clear but what's the problem? Does #134 block until this goes green?

digitalextremist commented 9 years ago

There's an rspec compatibility issue. I'll try to remedy it before #134 when I'm back from lunch.

tarcieri commented 9 years ago

I wouldn't be opposed to landing this despite the spec failures

digitalextremist commented 9 years ago

Yeah, I'm just going to merge this now and fiddle with tests separately.

ixti commented 9 years ago

@digitalextremist transpec helps a lot to update specs...

digitalextremist commented 9 years ago

That's very helpful @ixti, thank you!

@e2 is this what you've been doing? :)

digitalextremist commented 9 years ago

[ haha, now that all the tests are current :) ]

e2 commented 9 years ago

@digitalextremist - yeah, life would be hard without transpec. There are a few tricks, though (for outdated projects):

  1. first, update to RSpec 2.99, which is highly compatible with other 2.x versions + run tests
  2. update the spec/spec_helper config (remove stuff mostly) so tests run
  3. transpec + commit (best to temporarily add to Gemfile - best to use with Bundler)
  4. update to RSpec 3.2
  5. transpec again (will be different)
  6. remove transpec and update spec_helper with new RSpec features