celluloid / celluloid-io

UNMAINTAINED: See celluloid/celluloid#779 - Evented sockets for Celluloid actors
https://celluloid.io
MIT License
879 stars 93 forks source link

Stream#close is not called in subclasses #157

Closed hannesg closed 8 years ago

hannesg commented 8 years ago

Hi

I wondered why Stream#close is actually never called in the specs ( see coveralls ) although several sockets are closed. Turned out that all subclasses forward their close method directly to the internal socket and therefore bypass flushing the write buffer. Moreover the Stream#close method doesn't work at all because no subclass defines a sysclose method.

Cheers' Hannes

ioquatix commented 8 years ago

This looks good.

digitalextremist commented 8 years ago

:+1:

hannesg commented 8 years ago

Thanks :+1: