celluloid / celluloid-io

UNMAINTAINED: See celluloid/celluloid#779 - Evented sockets for Celluloid actors
https://celluloid.io
MIT License
879 stars 93 forks source link

Removed some Ruby warnings #51

Closed tbuehlmann closed 11 years ago

tbuehlmann commented 11 years ago

Removed some Ruby warnings. Not all, though, some are from dependencies.

coveralls commented 11 years ago

Coverage Status

Coverage decreased (-36.9%) when pulling b3b2958c9b1503ebd31f24d2957524d037f805a2 on tbuehlmann:master into 3a9367d31f2bd968ec359bba91f19877f47a3e14 on celluloid:master.

halorgium commented 11 years ago

I still get some warnings for:

lib/celluloid/io/reactor.rb:49: warning: instance variable lock_holder not initialized
tbuehlmann commented 11 years ago

Correct. I wasn't able to track that one down exactly. The source should be somewhere here.

halorgium commented 11 years ago

@tbuehlmann there was an odd JRuby error. I have restarted the build though.

halorgium commented 11 years ago

master is broken with jruby.