search

celluloid / celluloid-io

UNMAINTAINED: See celluloid/celluloid#779 - Evented sockets for Celluloid actors
https://celluloid.io
MIT License
879 stars 93 forks source link

More specific rescue. #88

Closed digitalextremist closed 10 years ago

tarcieri commented 10 years ago

I'm not really sure this addresses the problems. What if JRuby raised a TypeError internally?

I think the logic for deciding which implementation to use should happen ahead-of-time, not in a rescue block.

Also, I wouldn't worry too much as I plan on rewriting this all anyway ;)

digitalextremist commented 10 years ago

I am fine with an unspecific domino effect, with one exception suppressed in the meantime.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 6871a434a413f8f1be8314012e6ac6fb850cfb90 on digitalextremist:patch-1 into fdd66442f65715e14e27910a01ce0d7ef971915d on celluloid:master.