search

celluloid / dcell

UNMAINTAINED: See celluloid/celluloid#779 - Actor-based distributed objects in Ruby based on Celluloid and 0MQ
http://celluloid.io
MIT License
595 stars 65 forks source link

0.16.2 #101

Open niamster opened 9 years ago

niamster commented 9 years ago

To avoid confusion it's worth to release 0.16.2 from the current master.

@Zloy

Zloy commented 9 years ago

ok, I see. Thank you

digitalextremist commented 9 years ago

Right on, will do.

digitalextremist commented 9 years ago

I've cut 0.16.2

digitalextremist commented 9 years ago

@niamster noticing rspec failures though. May need to yank this. Can you look at it?

digitalextremist commented 9 years ago

@niamster: DCell.id is causing NoMethodError in node_manager.rb at line 25. Going to yank and retry at 0.16.3 once resolved.

digitalextremist commented 9 years ago

Yanked

digitalextremist commented 9 years ago

I'm on IRC if you need me.

niamster commented 9 years ago

Weird, I get

Assertion failed: check () (src/msg.cpp:248)

which comes from 0mq. Probably related to #99

niamster commented 9 years ago

finally the rspec for mri 2.2.1 in my docker container is ok. Have no idea what have happened to the host environment. On travis I see only failures for ZK, probably they have updated smth. @digitalextremist can you give the backtrace?

digitalextremist commented 9 years ago 
NoMethodError: undefined method `id' for DCell:Module
          register at /data/code/celluverse/dcell/lib/dcell/node_manager.rb:25
              find at /data/code/celluverse/dcell/lib/dcell/node_manager.rb:61
            (root) at /data/code/celluverse/dcell/spec/spec_helper.rb:32
     instance_exec at org/jruby/RubyBasicObject.java:1566
     instance_exec at /home/de/.rvm/gems/jruby-1.7.20/gems/rspec-core-3.3.1/lib/rspec/core/example.rb:378
               run at /home/de/.rvm/gems/jruby-1.7.20/gems/rspec-core-3.3.1/lib/rspec/core/hooks.rb:364
    run_hooks_with at /home/de/.rvm/gems/jruby-1.7.20/gems/rspec-core-3.3.1/lib/rspec/core/configuration.rb:1660
              each at org/jruby/RubyArray.java:1613
    run_hooks_with at /home/de/.rvm/gems/jruby-1.7.20/gems/rspec-core-3.3.1/lib/rspec/core/configuration.rb:1660
  with_suite_hooks at /home/de/.rvm/gems/jruby-1.7.20/gems/rspec-core-3.3.1/lib/rspec/core/configuration.rb:1629
         run_specs at /home/de/.rvm/gems/jruby-1.7.20/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:114
            report at /home/de/.rvm/gems/jruby-1.7.20/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:77
         run_specs at /home/de/.rvm/gems/jruby-1.7.20/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:113
               run at /home/de/.rvm/gems/jruby-1.7.20/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:89
               run at /home/de/.rvm/gems/jruby-1.7.20/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:73
            invoke at /home/de/.rvm/gems/jruby-1.7.20/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:41
            (root) at /home/de/.rvm/gems/jruby-1.7.20/gems/rspec-core-3.3.1/exe/rspec:4
              load at org/jruby/RubyKernel.java:1091
            (root) at /home/de/.rvm/gems/jruby-1.7.20/bin/rspec:1
              eval at org/jruby/RubyKernel.java:1111
            (root) at /home/de/.rvm/gems/jruby-1.7.20/bin/jruby_executable_hooks:15
niamster commented 9 years ago

Strange, I've tried with both jruby-1.7.19 and jruby-1.7.20 and don't see this issue. This might happen if DCell.start had never been called. In this particular case it must be invoked in config.before(:suite)

digitalextremist commented 9 years ago

Come to think of it, there might be something strange with my instance, even though I just recloned to make sure. None of the rspec tests are running. I assumed when I saw the Exception that there were failed tests, but it shows no tests, so therefore no failures, and then the exception.

digitalextremist commented 9 years ago

That was with jRuby 1.7.20 and this is with rbx-2.5.2

de@extremist /data/code/celluverse/dcell >> master $ rspec
[Coveralls] Using SimpleCov's default settings.

Finished in 0.00407 seconds (files took 9.02 seconds to load)
0 examples, 0 failures

An exception occurred running /home/de/.rvm/gems/rbx-2.5.2/bin/ruby_executable_hooks:

undefined method `id' on DCell (Module) (NoMethodError)

Backtrace:

                                 Kernel(Module)#id (method_missing) at kernel/delta/kernel.rb:78
                                          DCell::NodeCache.register at lib/dcell/node_manager.rb:25
                                DCell::NodeManager(Class)#[] (find) at lib/dcell/node_manager.rb:61
       { } in Object(RSpec::Core::AnonymousExampleGroup)#__script__ at spec/spec_helper.rb:32
      BasicObject(RSpec::Core::AnonymousExampleGroup)#instance_exec at kernel/common/eval.rb:101
  RSpec::Core::Example(RSpec::Core::SuiteHookContext)#instance_exec at /home/de/.rvm/gems/rbx-2.5.2/gems/rspec-core-3.3.1/lib/rspec/core/example.rb:378
                                  RSpec::Core::Hooks::AfterHook#run at /home/de/.rvm/gems/rbx-2.5.2/gems/rspec-core-3.3.1/lib/rspec/core/hooks.rb:364
                   { } in RSpec::Core::Configuration#run_hooks_with at /home/de/.rvm/gems/rbx-2.5.2/gems/rspec-core-3.3.1/lib/rspec/core/configuration.rb:1660
                                                         Array#each at kernel/bootstrap/array.rb:76
                          RSpec::Core::Configuration#run_hooks_with at /home/de/.rvm/gems/rbx-2.5.2/gems/rspec-core-3.3.1/lib/rspec/core/configuration.rb:1660
                        RSpec::Core::Configuration#with_suite_hooks at /home/de/.rvm/gems/rbx-2.5.2/gems/rspec-core-3.3.1/lib/rspec/core/configuration.rb:1629
                               { } in RSpec::Core::Runner#run_specs at /home/de/.rvm/gems/rbx-2.5.2/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:114
                                       RSpec::Core::Reporter#report at /home/de/.rvm/gems/rbx-2.5.2/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:77
                                      RSpec::Core::Runner#run_specs at /home/de/.rvm/gems/rbx-2.5.2/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:113
                                            RSpec::Core::Runner#run at /home/de/.rvm/gems/rbx-2.5.2/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:89
                                            RSpec::Core::Runner.run at /home/de/.rvm/gems/rbx-2.5.2/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:73
                                         RSpec::Core::Runner.invoke at /home/de/.rvm/gems/rbx-2.5.2/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:41
                                                  Object#__script__ at /home/de/.rvm/gems/rbx-2.5.2/gems/rspec-core-3.3.1/exe/rspec:4
                                                Kernel(Object)#load at kernel/common/kernel.rb:497
                                           { } in Object#__script__ at /home/de/.rvm/gems/rbx-2.5.2/bin/rspec:23
                        Rubinius::BlockEnvironment#call_on_instance at kernel/common/block_environment.rb:53
                                                Kernel(Object)#eval at kernel/common/eval.rb:176
                                                  Object#__script__ at /home/de/.rvm/gems/rbx-2.5.2/bin/ruby_executable_hooks:15
                                   Rubinius::CodeLoader#load_script at kernel/delta/code_loader.rb:66
                                   Rubinius::CodeLoader.load_script at kernel/delta/code_loader.rb:152
                                            Rubinius::Loader#script at kernel/loader.rb:655
                                              Rubinius::Loader#main at kernel/loader.rb:809
Coverage report generated for spec to /data/code/celluverse/dcell/coverage. 547 / 565 LOC (96.81%) covered.
digitalextremist commented 9 years ago

Wait, I see some issues with my instance. But also with the repo. Resolving.

niamster commented 9 years ago

With rbx-2.5.2 I have smth weird

    unlinks from remote actors
*** Error in `/home/niam/.rvm/rubies/rbx-2.5.2/bin/rbx': free(): invalid next size (fast): 0x00007f226408b270 ***
The Rubinius process is aborting with signal: SIGABRT
--- begin system info ---
sysname: Linux
nodename: baadf4c462cf
release: 4.0.5-1-ARCH
version: #1 SMP PREEMPT Sat Jun 6 18:37:49 CEST 2015
machine: x86_64
--- end system info ---
--- begin rubinius info ---
program name: rbx
version: 2.5.2
ruby version: 2.1.0
release date: 2015-01-30
build revision: 7a5b05b1a9aca87703ceb0bafe00b916b9510285
llvm version: 3.4
--- end rubinius info ---
--- begin system backtrace ---
...
jessesanford commented 8 years ago

Wha is the state of this? This ticket is a year old and the 0.16.2 version has not been cut as far as I can tell?!