search

celluloid / dcell

UNMAINTAINED: See celluloid/celluloid#779 - Actor-based distributed objects in Ruby based on Celluloid and 0MQ
http://celluloid.io
MIT License
595 stars 65 forks source link

0-15-stable broken with finalizer changes #73

Closed jasonayre closed 9 years ago

jasonayre commented 10 years ago

Pull request #71 which was merged into the "stable" branch seems to have broken things far worse

Node1 connects to registry Node2 connects to registry, calls method on node1, still working

Node2 disconnects Finalizer clears ENTIRE registry Node2 reconnects

Node 1 no longer exists to node2 or any node for that matter since it cleared the entire registry. Will require a restart of process to become visible again. (but actually, if you restart the process, it clears the registry yet again, triggering an infinite clearing of the registry which will not be in sync until all nodes are taken offline at same time, then brought back up)

niamster commented 9 years ago

Probably it's the same as in #77. Check out the pull request #78

niamster commented 9 years ago

Fixed in master, do we need this in 0-15? I believe that fixing the celluloid versions to 0.15 should be enough.