Closed niamster closed 9 years ago
I'm going to merge this silently this WE if no objections. Once merged I will update wiki.
Awesome, thanks for the huge effort here.
@niamster wanted to do a more detailed review but haven't had time yet. Maybe let me at least leave some notes tonight?
@tarcieri take your time. It was just a ping ;). I have another tree where I'm addressing stability and fast node recovery. Once this is merged I'll be about to create a new pull request. @ioquatix thanks
A few stylistic notes, minor nits, and genuine concerns about UUIDs. Other than that I'd say ship it :shipit:
@niamster also I just got Ruby accepted as a toplevel GSoC organization. Let me know if you'd be interested in mentoring a student on a DCell-related project
@tarcieri thanks a lot for reviewing it. You have a sharp eye ;). Do you prefer a brand new pull request or just a commit to clean this mess is enough?
@tarcieri it would be an honour to help a student with a dcell project.
@niamster if you want, you can go ahead and merge it and do a followup PR with cleanups. That makes it easier to review the cleanups.
If you're interested in being a Ruby GSoC mentor, sign up on this list:
https://groups.google.com/forum/?hl=en#!forum/rubygsoc
And add your DCell ideas to the Ideas List:
On a unrelated note, czmq is getting/just got a official Ruby binding which is part of the normal package, i will try to get in on par with what i have written and place a note on my wrapper that its no longer being maintained.
https://github.com/zeromq/czmq/tree/master/bindings/ruby/lib/czmq/ffi
There's a bunch of changes:
End-user visible changes
Functional changes
Misc
Attention
Registry backend API has been changed and not backward compatible. From now on the node holds opaque metadata object(previously address as a string). Also registries now use msgpack to serialize the data.