Closed stouset closed 10 years ago
lgtm so far
So.. how are you supposed to create a unix Server now? Calling Reel::Server.unix only throws an exception because the super in there can't do anything.
You're right. I'd been waiting for feedback on the approach before writing tests, but the factory is broken as currently written.
:cry:
What about changing the API and adding something like URL schemes to setup Servers? Have wrapped it up a bit
Would still love it to be able to write down a url like Reel::Server.new('https:///path/to/socket') to start a new Server ^^
Interestingly, doing it this way ended up removing a bunch of code from SSLServer. It shouldn't be too difficult to merge this PR with my previous one to add verification of client SSL certs.
Tests are forthcoming. Wanted to get this out there for comment first.