search

celluloid / reel

UNMAINTAINED: See celluloid/celluloid#779 - Celluloid::IO-powered web server
https://celluloid.io
MIT License
596 stars 87 forks source link

Allow for serving HTTP over UNIX sockets #115

Closed stouset closed 10 years ago

stouset commented 10 years ago

Interestingly, doing it this way ended up removing a bunch of code from SSLServer. It shouldn't be too difficult to merge this PR with my previous one to add verification of client SSL certs.

Tests are forthcoming. Wanted to get this out there for comment first.

sconover commented 10 years ago

lgtm so far

Asmod4n commented 10 years ago

So.. how are you supposed to create a unix Server now? Calling Reel::Server.unix only throws an exception because the super in there can't do anything.

stouset commented 10 years ago

You're right. I'd been waiting for feedback on the approach before writing tests, but the factory is broken as currently written.

tarcieri commented 10 years ago

:cry:

Asmod4n commented 10 years ago

What about changing the API and adding something like URL schemes to setup Servers? Have wrapped it up a bit

https://gist.github.com/Asmod4n/2a340d35da82a4ffda1b

stouset commented 10 years ago

@Asmod4n I already have a fix that includes the promised tests. :)

Asmod4n commented 10 years ago

Would still love it to be able to write down a url like Reel::Server.new('https:///path/to/socket') to start a new Server ^^