search

celluloid / reel

UNMAINTAINED: See celluloid/celluloid#779 - Celluloid::IO-powered web server
https://celluloid.io
MIT License
595 stars 87 forks source link

Refactor Reel::Server, refactor/retrofit/abandon SocketMixin #121

Closed digitalextremist closed 10 years ago

digitalextremist commented 10 years ago

Closes #114, Closes #119, Closes #120

digitalextremist commented 10 years ago

Alright, the moment of truth... all tests running, with both rbx and rbx-2

digitalextremist commented 10 years ago

rbx seems to do the same version as rbx-2 so we may as well choose only one.

digitalextremist commented 10 years ago

Coming back to pull the trigger on this merge when you feel comfortable with the PR @tarcieri. rbx seems like it's going to be fine, and I can remove rbx-2 going forward.

digitalextremist commented 10 years ago

@tarcieri you may want to check Gemfile per the comments made in https://github.com/travis-ci/travis-ci/issues/1641 about it. What I added may not be necessary with the rbx fix.

And I will see if rbx-2 affects which ruby language version is tested.

digitalextremist commented 10 years ago

...and rbx crashes into the terrain...

tarcieri commented 10 years ago

@digitalextremist looks like you can probably just use "rbx". Surprised it's failing with rubysl in the Gemfile

I'd say let's just move rbx to allowed failures for now (and leave out rbx-2 since it's the same thing)

digitalextremist commented 10 years ago

@tarcieri, after what we've just gone through and seen, this commit will pass. Newline added, and failure of rbx accepted, as well as rbx-2 removed.

digitalextremist commented 10 years ago

All green with the one allowed red.

digitalextremist commented 10 years ago

Last things that ought to be looked at later and can move to separate issues, which are @stouset territory:

All set to merge, and move those two things into their own issues.

Update: The issues were created, and added above.

digitalextremist commented 10 years ago

Come to think of it @tarcieri, since this affects a lot of past code out there in the wild and will break that code, #126 ought to happen as simultaneously as possible. I am open to scheduling that at a point you are comfortable with it, volunteering to do the Wiki changes and then immediately come and merge this in once the documentation isn't one huge o_0 field of uhhh? And I could also write a post on the mailinglist about this unless someone else would be better.

tarcieri commented 10 years ago

@digitalextremist this is definitely a breaking change that needs to be well-advertised, and I agree about #126

digitalextremist commented 10 years ago

Cool @tarcieri, I am all over #126.

tarcieri commented 10 years ago

Sweet, thank you!

tarcieri commented 10 years ago

This is good to merge

tarcieri commented 10 years ago

:tada: :tada: :tada: :shipit: :thumbsup:

digitalextremist commented 10 years ago

:smiley: I'm stupid happy.

Wiki fully updated. Only thing left on #126 is the mailing list post.

Can you check over the Wiki when you get a chance?

tarcieri commented 10 years ago

Sure, will probably be some time tomorrow

digitalextremist commented 10 years ago

Cool @tarcieri, I am done for today then and left everything at #126 for you to go through when it's good for you.

tarcieri commented 10 years ago

Thanks again!

digitalextremist commented 10 years ago

My pleasure :+1:

I am honored to step in, stick around, and see 1.0 & beyond spread far and wide.

halorgium commented 10 years ago

Nice work! Now we need celluloid 1.0!