Closed Asmod4n closed 10 years ago
This is a bit funky because the semantics are different between the response types (e.g. IO)
If we want the contract to be that Reel consistently closes the body object after it's been streamed, it should do that consistently for all response types.
So adding it to the end of handle_response would be better?
Yes, sure
Looks good, thanks
Webmachine-Ruby Encodes IO Objects as a Enumerable. (https://github.com/seancribbs/webmachine-ruby/blob/master/lib/webmachine/decision/helpers.rb#L27 and https://github.com/seancribbs/webmachine-ruby/blob/master/lib/webmachine/streaming/io_encoder.rb#L9) This depends on https://github.com/seancribbs/webmachine-ruby/issues/145 Another possible way to handle it would be
But Celluloid::IO doesn't do anything then.