search

celluloid / reel

UNMAINTAINED: See celluloid/celluloid#779 - Celluloid::IO-powered web server
https://celluloid.io
MIT License
596 stars 87 forks source link

Fix for the latest http gem. #138

Closed unakatsuo closed 10 years ago

unakatsuo commented 10 years ago

tarcieri/http#80 introduced new API and it interferes Reel to stop with syntax error.

/home/travis/.rvm/rubies/ruby-2.0.0-p353/bin/ruby -S rspec ./spec/reel/connection_spec.rb ./spec/reel/http_server_spec.rb ./spec/reel/https_server_spec.rb ./spec/reel/response/writer_spec.rb ./spec/reel/response_spec.rb ./spec/reel/websocket_spec.rb
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's default settings.
/home/travis/build/unakatsuo/reel/lib/reel/response.rb:5:in `<class:Response>': uninitialized constant HTTP::Header (NameError)
    from /home/travis/build/unakatsuo/reel/lib/reel/response.rb:4:in `<module:Reel>'
    from /home/travis/build/unakatsuo/reel/lib/reel/response.rb:3:in `<top (required)>'

This PR fixes the API compatibility issue in Reel::Response.

tarcieri commented 10 years ago

Looks good, thanks!

SaitoWu commented 10 years ago

Please release a new version of Reel. cause http gem has been updated!

tarcieri commented 10 years ago

I can at least push up a .pre

tarcieri commented 10 years ago

I released Reel 0.5.0 yesterday