celluloid / reel

UNMAINTAINED: See celluloid/celluloid#779 - Celluloid::IO-powered web server
https://celluloid.io
MIT License
596 stars 87 forks source link

0.6.0 release can't ping websocket clients #222

Closed kenichi closed 8 years ago

kenichi commented 8 years ago

can we cut a 0.6.1 with the no rack PR in it? it also contains a forward to websocket-driver's ping, so that reel servers can ping websocket clients without having to do any instance_variable_get :@driver stuff.

angelo, in its endeavor to make websockets "easy", sets up automatic ping tasks on the reactor when websockets connect, and they crash on 0.6.0:

E, [2016-03-10T09:58:13.845297 #77156] ERROR -- : Actor crashed!
NoMethodError: undefined method `ping' for #<Reel::WebSocket:0x007fa2d5884ee0>
tarcieri commented 8 years ago

Yes, will do this this weekend

tarcieri commented 8 years ago

0.6.1 released

kenichi commented 8 years ago

awesome. thanks!