celluloid / reel

UNMAINTAINED: See celluloid/celluloid#779 - Celluloid::IO-powered web server
https://celluloid.io
MIT License
596 stars 87 forks source link

rackup - Reel fail to start when specifying the number of workers using the -O switch #57

Closed eranb closed 11 years ago

eranb commented 11 years ago

it's a small fix, I'll submit a patch

bundle exec rackup -s reel  -O 'workers=12'
I, [2013-05-06T23:06:13.125833 #65831]  INFO -- : A Reel good HTTP server!
I, [2013-05-06T23:06:13.125977 #65831]  INFO -- : Listening on 0.0.0.0:9292
E, [2013-05-06T23:06:13.127846 #65831] ERROR -- : Celluloid::PoolManager crashed!
ArgumentError: comparison of String with 2 failed
    /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid/pool_manager.rb:14:in `<'
    /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid/pool_manager.rb:14:in `initialize'
    /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid/calls.rb:11:in `public_send'
    /Users/eran/.rvm/Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid/pool_manager.rb:14:in `<': comparison of String with 2 failed (ArgumentError)
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid/pool_manager.rb:14:in `initialize'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid/calls.rb:11:in `public_send'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid/calls.rb:11:in `dispatch'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid/calls.rb:63:in `dispatch'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid/actor.rb:326:in `block in handle_message'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid/tasks/task_fiber.rb:28:in `block in initialize'
    from (celluloid):0:in `remote procedure call'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid/actor.rb:69:in `call'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid/proxies/actor_proxy.rb:26:in `_send_'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid.rb:104:in `new'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/celluloid-0.13.0/lib/celluloid.rb:138:in `pool'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/reel-0.3.0/lib/rack/handler/reel.rb:40:in `start'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/reel-0.3.0/lib/rack/handler/reel.rb:26:in `run'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/rack-1.5.2/lib/rack/server.rb:264:in `start'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/rack-1.5.2/lib/rack/server.rb:141:in `start'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/gems/rack-1.5.2/bin/rackup:4:in `<top (required)>'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/bin/rackup:19:in `load'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/bin/rackup:19:in `<main>'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/bin/ruby_noexec_wrapper:14:in `eval'
    from /Users/eran/.rvm/gems/ruby-1.9.3-p392@webserver-bench/bin/ruby_noexec_wrapper:14:in `<main>'