search

celluloid / reel

UNMAINTAINED: See celluloid/celluloid#779 - Celluloid::IO-powered web server
https://celluloid.io
MIT License
595 stars 87 forks source link

Support WSS #61

Closed perlun closed 11 years ago

perlun commented 11 years ago

Hi,

Is it just me who can't find the documentation, or is it currently impossible to use Reel with WSS (TLS-secured websockets)? If it is just me - please let me know how to do it. :)

(Can't seem to find the option where to enable it, so I presume it is not yet implemented.)

Best regards, Per

tarcieri commented 11 years ago

I'd definitely like to add support for Reel to terminate TLS itself. This has actually been requested a few times now. There is unfortunately no support at present, but actually getting this going is surprisingly easy due to the way Reel is factored.

halorgium commented 11 years ago

@tarcieri should we allow injecting a *Server socket into the Reel::Server actor?

tarcieri commented 11 years ago

@halorgium that'd be cool, and helpful for doing a "prefork" model (if we ever get support for sharing sockets across reactors)

halorgium commented 11 years ago

@tarcieri indeed. I wonder if we should guard against multi-actor sharing at this stage.

tarcieri commented 11 years ago

Initial SSL support here:

https://github.com/celluloid/reel/commit/3c6350e21c0fa202e6912d6077f4b1091dd0965e

perlun commented 11 years ago

Looks promising! @halorgium - yes, guarding against multi-actor sharing is probably a good thing, especially if it is not supposed to work correctly. ;)

tarcieri commented 11 years ago

I believe WSS should now be supported via the existing SSL implementation. Reopen if you have problems