Updated to conform to http_parser.rb 0.6.0.beta.2 and greater.

celluloid / reel

UNMAINTAINED: See celluloid/celluloid#779 - Celluloid::IO-powered web server

https://celluloid.io

MIT License

596 stars 87 forks source link

Updated to conform to http_parser.rb 0.6.0.beta.2 and greater. #63

Closed digitalextremist closed 11 years ago

digitalextremist commented 11 years ago

Now current with 0.6.0.beta.2 and greater, but will also be fine with 0.5.3 I would guess.

Updated gemspec to call for the jRuby compatible http_parser.rb Updated Reel::Request::Parser via RequestMixins

Removed the missing methods from Reel::Request::Parser Updated query_string and path methods of RequestMixin

( made sure to invoke the existing uri method which ought to be an instance of URI after the first call to uri )

digitalextremist commented 11 years ago

This completely solves #40

digitalextremist commented 11 years ago

This also solves #62

coveralls commented 11 years ago

Coverage increased (+0%) when pulling 42b5f82c78797ab4b77fb78125a8aa1f52fe6552 on digitalextremist:http_parser.rb-0.6.0.betas into d7e7ee228e4fdcc92ce9742a6ba42eb1e2d3b8f9 on celluloid:master.

coveralls commented 11 years ago

Coverage increased (+0%) when pulling eaee14fcd41a9b4694d214bdfd278c0a73bae1bf on digitalextremist:http_parser.rb-0.6.0.betas into d7e7ee228e4fdcc92ce9742a6ba42eb1e2d3b8f9 on celluloid:master.

coveralls commented 11 years ago

Coverage increased (+0%) when pulling 026a865f50104f3102cda5e3de5a21aff738374c on digitalextremist:http_parser.rb-0.6.0.betas into d7e7ee228e4fdcc92ce9742a6ba42eb1e2d3b8f9 on celluloid:master.

tarcieri commented 11 years ago

Thanks for all the work on this, and apologies for taking so long to merge it. I thought there was more to review here, but apparently not.

digitalextremist commented 11 years ago

Yeah it was pretty straight-forward. Been away for a while but I'm back, and glad to see this merged in!