search

celluloid / reel

UNMAINTAINED: See celluloid/celluloid#779 - Celluloid::IO-powered web server
https://celluloid.io
MIT License
596 stars 87 forks source link

Add SSLServer Support #65

Closed knewter closed 11 years ago

knewter commented 11 years ago

There's one failing test still, not sure what's up with it. Anything I should do differently here?

coveralls commented 11 years ago

Coverage Status

Coverage remained the same when pulling 9fac30f945ec593a4af097988af2dbb842cb6227 on knewter:feature/tls_only into d7e7ee228e4fdcc92ce9742a6ba42eb1e2d3b8f9 on celluloid:master.

tarcieri commented 11 years ago

I think we'd need to evaluate the (backwards incompatible) API changes before merging this.

I think it would maybe make sense to have a separate Reel::SSLServer class which exposes the SSL-specific stuff, or perhaps an options hash to Reel::Server to pass in SSL-related parameters

bernd commented 11 years ago

:+1: for a Reel::SSLServer class.

knewter commented 11 years ago

I'll spike Reel::SSLServer

On Fri, May 31, 2013 at 12:51 PM, Bernd Ahlers notifications@github.comwrote:

[image: :+1:] for a Reel::SSLServer class.

— Reply to this email directly or view it on GitHubhttps://github.com/celluloid/reel/pull/65#issuecomment-18760688 .

Josh Adams CTO | isotope|eleven http://www.isotope11.com cell 215-3957 work 476-8671 x201

coveralls commented 11 years ago

Coverage Status

Coverage remained the same when pulling 3881e0d5e8a1acbce7cadbbfa65eecb45f4637b0 on knewter:feature/tls_only into d7e7ee228e4fdcc92ce9742a6ba42eb1e2d3b8f9 on celluloid:master.

coveralls commented 11 years ago

Coverage Status

Coverage remained the same when pulling f0279a687fd5d239c56bd92d7b473e5f0587b2cf on knewter:feature/tls_only into d7e7ee228e4fdcc92ce9742a6ba42eb1e2d3b8f9 on celluloid:master.

tarcieri commented 11 years ago

Well, as it so happens I need SSL support in Reel myself and have a use case. I don't think this is a particularly useful start though, for a number of reasons. There's still no distinct SSLServer class in your PR, and you've changed the examples to only test the SSL path, instead of testing both.

I hope you don't mind but I'm going to pursue SSL support myself, trying to keep it isolated and tested separately from the non-SSL code

knewter commented 11 years ago

I'm not hurt by this. I was in a rush to get it functional and thought it might be helpful but in no way thought it was good :)

Also, would suggest you might still have to deal with the hanging sslsocket in jruby before it works there.

Thanks for all them things you do :) On Jun 13, 2013 8:14 PM, "Tony Arcieri" notifications@github.com wrote:

Well, as it so happens I need SSL support in Reel myself and have a use case. I don't think this is a particularly useful start though, for a number of reasons. There's still no distinct SSLServer class in your PR, and you've changed the examples to only test the SSL path, instead of testing both.

I hope you don't mind but I'm going to pursue SSL support myself, trying to keep it isolated and tested separately from the non-SSL code

— Reply to this email directly or view it on GitHubhttps://github.com/celluloid/reel/pull/65#issuecomment-19432910 .