Closed fbernier closed 11 years ago
Looks like it's failing ... be right back.
If you can push again (perhaps edit a commit message and force push) it should trigger the build again
:white_check_mark:
Seems good, thanks!
I've already been using that in my branch, however I also have these. Ought I push them into a pull request?
socket.setsockopt( Socket::IPPROTO_TCP, :TCP_NODELAY, 1 )
socket.setsockopt( Socket::IPPROTO_TCP, 3, 1 ) # TCP_CORK
socket.setsockopt( Socket::SOL_SOCKET, Socket::SO_REUSEADDR, 1 )
REUSEADDR would be good. I don't think that usage of TCP_CORK alone will work, though
Ok I will do that. TCP_CORK works with TCP_NODELAY but both or one of them are linux only so I trap by OS.
I don't get how TCP_CORK works if you're never uncorking
I believe 3
is UNCORK, I can find the actual man page for this to verify.
That doesn't help unless you've corked...
For a webserver where requests/responses are usually large enough to be contained in a packet, the Nagle's algorithm slows the last packet sent.
This configuration is probably used in most ruby web servers. I only checked for Puma though.