celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

Karlb/cip35 debug #2123

Closed karlb closed 1 year ago

karlb commented 1 year ago

Description

A few sentences describing the overall effects and goals of the pull request's commits. What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 67.81% and project coverage change: +0.66 :tada:

Comparison is base (71bdbcf) 54.30% compared to head (46da079) 54.96%.

:exclamation: Current head 46da079 differs from pull request most recent head d02951b. Consider uploading reports for the commit d02951b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2123 +/- ## ========================================== + Coverage 54.30% 54.96% +0.66% ========================================== Files 692 564 -128 Lines 115642 93503 -22139 ========================================== - Hits 62795 51397 -11398 + Misses 49014 39151 -9863 + Partials 3833 2955 -878 ``` | [Impacted Files](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | Coverage Δ | | |---|---|---| | [cmd/devp2p/internal/ethtest/transaction.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y21kL2RldnAycC9pbnRlcm5hbC9ldGh0ZXN0L3RyYW5zYWN0aW9uLmdv) | `0.00% <0.00%> (ø)` | | | [cmd/geth/chaincmd.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y21kL2dldGgvY2hhaW5jbWQuZ28=) | `0.00% <0.00%> (ø)` | | | [cmd/geth/main.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y21kL2dldGgvbWFpbi5nbw==) | `21.39% <ø> (+0.91%)` | :arrow_up: | | [cmd/geth/usage.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y21kL2dldGgvdXNhZ2UuZ28=) | `10.90% <ø> (ø)` | | | [cmd/utils/flags.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y21kL3V0aWxzL2ZsYWdzLmdv) | `2.56% <0.00%> (ø)` | | | [consensus/istanbul/utils.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29uc2Vuc3VzL2lzdGFuYnVsL3V0aWxzLmdv) | `47.10% <ø> (+1.13%)` | :arrow_up: | | [contracts/currency/currency.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29udHJhY3RzL2N1cnJlbmN5L2N1cnJlbmN5Lmdv) | `55.00% <ø> (ø)` | | | [contracts/election/election.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29udHJhY3RzL2VsZWN0aW9uL2VsZWN0aW9uLmdv) | `25.00% <ø> (ø)` | | | [contracts/epoch\_rewards/epoch\_rewards.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29udHJhY3RzL2Vwb2NoX3Jld2FyZHMvZXBvY2hfcmV3YXJkcy5nbw==) | `88.88% <ø> (ø)` | | | [contracts/freezer/freezer.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29udHJhY3RzL2ZyZWV6ZXIvZnJlZXplci5nbw==) | `70.00% <ø> (ø)` | | | ... and [40 more](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | | ... and [134 files with indirect coverage changes](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2123/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.