celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

Restore baseFee opcode #2128

Closed gastonponti closed 1 year ago

gastonponti commented 1 year ago

Description

Implementation of the CIP-61: Restore BaseFee opcode/header field.

Tested

Run test, e2e tests, and spin a testnet checking the hf switch in a heavy load

Related issues

Backwards compatibility

This is part of the Gingerbread hardfork

github-actions[bot] commented 1 year ago
5856 passed, 45 skipped
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 30.39% and project coverage change: -0.02 :warning:

Comparison is base (424ce92) 55.24% compared to head (d4ad096) 55.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2128 +/- ## ========================================== - Coverage 55.24% 55.23% -0.02% ========================================== Files 672 676 +4 Lines 113066 113886 +820 ========================================== + Hits 62464 62905 +441 - Misses 46789 47125 +336 - Partials 3813 3856 +43 ``` | [Impacted Files](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | Coverage Δ | | |---|---|---| | [cmd/utils/flags.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y21kL3V0aWxzL2ZsYWdzLmdv) | `2.54% <ø> (ø)` | | | [consensus/istanbul/backend/engine.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29uc2Vuc3VzL2lzdGFuYnVsL2JhY2tlbmQvZW5naW5lLmdv) | `62.26% <0.00%> (-0.84%)` | :arrow_down: | | [contracts/gasprice\_minimum/gasprice\_minimum.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29udHJhY3RzL2dhc3ByaWNlX21pbmltdW0vZ2FzcHJpY2VfbWluaW11bS5nbw==) | `43.75% <0.00%> (-5.65%)` | :arrow_down: | | [core/types/block.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29yZS90eXBlcy9ibG9jay5nbw==) | `32.29% <0.00%> (-1.04%)` | :arrow_down: | | [eth/api\_backend.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-ZXRoL2FwaV9iYWNrZW5kLmdv) | `0.00% <0.00%> (ø)` | | | [eth/filters/api.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-ZXRoL2ZpbHRlcnMvYXBpLmdv) | `43.42% <0.00%> (-1.03%)` | :arrow_down: | | [ethclient/ethclient.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-ZXRoY2xpZW50L2V0aGNsaWVudC5nbw==) | `32.49% <0.00%> (-0.28%)` | :arrow_down: | | [internal/ethapi/api.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-aW50ZXJuYWwvZXRoYXBpL2FwaS5nbw==) | `3.89% <0.00%> (-0.04%)` | :arrow_down: | | [les/api\_backend.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-bGVzL2FwaV9iYWNrZW5kLmdv) | `0.00% <0.00%> (ø)` | | | [les/test\_helper.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-bGVzL3Rlc3RfaGVscGVyLmdv) | `89.17% <ø> (-0.44%)` | :arrow_down: | | ... and [13 more](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | | ... and [30 files with indirect coverage changes](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2128/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

palango commented 1 year ago

What's the relation of this PR and https://github.com/celo-org/celo-monorepo/pull/10274? Do we need to wait until the update is merged or do we just pull the changes in our monorepo branch? If so, will that cause problems with the v10 contracts release?

github-actions[bot] commented 1 year ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit b9a80e5fd9de1a43bc5d437f9501c3588ff88f17

coverage: 47.6% of statements across all listed packages
coverage:  59.6% of statements in consensus/istanbul
coverage:  40.4% of statements in consensus/istanbul/announce
coverage:  54.5% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  57.7% of statements in consensus/istanbul/core
coverage:  45.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random