search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

Simplify interface of proofOfPossession precompile #2129

Closed palango closed 1 year ago

palango commented 1 year ago

Description

Fix a small oversight in #2103

github-actions[bot] commented 1 year ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit c6e1af5c58fbcef38effa1e4876380381c3c1ba5

coverage: 49.2% of statements across all listed packages 
coverage:  60.0% of statements in consensus/istanbul
coverage:  43.0% of statements in consensus/istanbul/announce
coverage:  55.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  60.4% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 1 year ago
5814 passed, 44 skipped
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 64.76% and project coverage change: +0.98 :tada:

Comparison is base (71bdbcf) 54.30% compared to head (dc6b33b) 55.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2129 +/- ## ========================================== + Coverage 54.30% 55.28% +0.98% ========================================== Files 692 674 -18 Lines 115642 113509 -2133 ========================================== - Hits 62795 62758 -37 + Misses 49014 46940 -2074 + Partials 3833 3811 -22 ``` | [Impacted Files](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | Coverage Δ | | |---|---|---| | [cmd/devp2p/internal/ethtest/transaction.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y21kL2RldnAycC9pbnRlcm5hbC9ldGh0ZXN0L3RyYW5zYWN0aW9uLmdv) | `0.00% <0.00%> (ø)` | | | [cmd/geth/chaincmd.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y21kL2dldGgvY2hhaW5jbWQuZ28=) | `0.00% <0.00%> (ø)` | | | [cmd/geth/main.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y21kL2dldGgvbWFpbi5nbw==) | `21.39% <ø> (+0.91%)` | :arrow_up: | | [cmd/geth/usage.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y21kL2dldGgvdXNhZ2UuZ28=) | `10.90% <ø> (ø)` | | | [cmd/utils/flags.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y21kL3V0aWxzL2ZsYWdzLmdv) | `2.56% <0.00%> (ø)` | | | [consensus/istanbul/utils.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29uc2Vuc3VzL2lzdGFuYnVsL3V0aWxzLmdv) | `47.10% <ø> (+1.13%)` | :arrow_up: | | [contracts/currency/currency.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29udHJhY3RzL2N1cnJlbmN5L2N1cnJlbmN5Lmdv) | `55.00% <ø> (ø)` | | | [contracts/election/election.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29udHJhY3RzL2VsZWN0aW9uL2VsZWN0aW9uLmdv) | `25.00% <ø> (ø)` | | | [contracts/epoch\_rewards/epoch\_rewards.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29udHJhY3RzL2Vwb2NoX3Jld2FyZHMvZXBvY2hfcmV3YXJkcy5nbw==) | `88.88% <ø> (ø)` | | | [contracts/freezer/freezer.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29udHJhY3RzL2ZyZWV6ZXIvZnJlZXplci5nbw==) | `70.00% <ø> (ø)` | | | ... and [48 more](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | | ... and [38 files with indirect coverage changes](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2129/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.