search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

Remove LES v4 and v5 protocols #2143

Closed palango closed 1 year ago

palango commented 1 year ago

Description

Remove the latest LES protocol versions. This will make GetGatewayFeeMsg and GatewayFeeMsg unused. They cannot be removed yet as they are used in the JS API, but removal will be possible after gingerbread.

github-actions[bot] commented 1 year ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 3741306cde3a0738dfa4243b2d37b8e3737b6fbc

coverage: 48.5% of statements across all listed packages 
coverage:  59.8% of statements in consensus/istanbul
coverage:  43.3% of statements in consensus/istanbul/announce
coverage:  55.8% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  57.7% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 1 year ago

5720 passed, 2 failed, 34 skipped

Test failures:
  TestPriorityClient: geth
    les_test.go:121: Initializing geth: [--networkid=42 init ./testdata/clique.json]
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.141] Maximum peer count                       ETH=175 LES=0 total=175
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.144] Set global gas inflation rate            rate=1.300
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.144] Set global gas cap                       cap=25,000,000
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.144] Allocated cache and file handles         database=/tmp/geth-test2641949100/celo/chaindata cache=16.00MiB handles=16
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.157] Writing custom genesis block
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.159] Persisted trie from memory database      nodes=4 size=566.00B time="604.578µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=-82.00B
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.160] Successfully wrote genesis state         database=chaindata                               hash=9195f2..122dcd
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.160] Allocated cache and file handles         database=/tmp/geth-test2641949100/celo/lightchaindata cache=16.00MiB handles=16
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.171] Writing custom genesis block
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.172] Persisted trie from memory database      nodes=4 size=566.00B time="71.658µs"  gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=-82.00B
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.172] Successfully wrote genesis state         database=lightchaindata                          hash=9195f2..122dcd
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.172] Allocated cache and file handles         database=/tmp/geth-test2641949100/celo/lightestchaindata cache=16.00MiB handles=16
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.184] Writing custom genesis block
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.185] Persisted trie from memory database      nodes=4 size=566.00B time="39.064µs"  gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=-82.00B
test_cmd.go:262: (stderr:31) INFO [06-27|13:02:23.185] Successfully wrote genesis state         database=lightestchaindata                       hash=9195f2..122dcd
les_test.go:130: Importing keys to geth
test_cmd.go:262: (stderr:32) INFO [06-27|13:02:23.229] Maximum peer count                       ETH=175 LES=0 total=175
test_cmd.go:262: (stderr:32) INFO [06-27|13:02:23.232] Set global gas inflation rate            rate=1.300
test_cmd.go:262: (stderr:32) INFO [06-27|13:02:23.232] Set global gas cap                       cap=25,000,000
les_test.go:99: Starting lightserver with rpc: [--networkid=42 --port=0 --ipcpath geth-1.ipc --allow-insecure-unlock --datadir /tmp/geth-test2641949100 --password ./testdata/password.txt --unlock 0x02f0d131f1f97aef08aec6e3291b957d9efe7105 --mine --miner.validator 0x02f0d131f1f97aef08aec6e3291b957d9efe7105 --tx-fee-recipient 0x02f0d131f1f97aef08aec6e3291b957d9efe7105 --light.serve=100 --light.maxpeers=1 --nodiscover --nat=extip:127.0.0.1 --verbosity=4]
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.449] Maximum peer count                       ETH=175 LES=1 total=176
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.449] FS scan times                            list="34.45µs" set="3.245µs" diff="1.803µs"
test_cmd.go:262: (stderr:33) WARN [06-27|13:02:23.453] LES server cannot serve old transaction status and cannot connect below les/4 protocol version if transaction lookup index is limited
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.453] Sanitizing Go's GC trigger               percent=100
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.453] Set global gas inflation rate            rate=1.300
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.453] Set global gas cap                       cap=25,000,000
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.453] Allocated trie memory caches             clean=154.00MiB dirty=256.00MiB
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.453] Allocated cache and file handles         database=/tmp/geth-test2641949100/celo/chaindata cache=512.00MiB handles=524,288
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.483] Chain freezer table opened               database=/tmp/geth-test2641949100/celo/chaindata/ancient table=diffs items=0 size=0.00B
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.486] Chain freezer table opened               database=/tmp/geth-test2641949100/celo/chaindata/ancient table=headers items=0 size=0.00B
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.488] Chain freezer table opened               database=/tmp/geth-test2641949100/celo/chaindata/ancient table=hashes  items=0 size=0.00B
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.490] Chain freezer table opened               database=/tmp/geth-test2641949100/celo/chaindata/ancient table=bodies  items=0 size=0.00B
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.493] Chain freezer table opened               database=/tmp/geth-test2641949100/celo/chaindata/ancient table=receipts items=0 size=0.00B
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.493] Opened ancient database                  database=/tmp/geth-test2641949100/celo/chaindata/ancient readonly=false
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.494] Initialised chain configuration          config="{ChainID: 15 Homestead: 0 DAO:  DAOSupport: false EIP150: 0 EIP155: 0 EIP158: 0 Byzantium: 0 Constantinople: 0 Petersburg: 0 Istanbul:  Churrito: , Donut: , Espresso: , Gingerbread: , Engine: istanbul}"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.494] Current full block not old enough        number=0 hash=9195f2..122dcd delay=90000
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.494] Setting up Istanbul consensus engine
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.544] Initialising Ethereum protocol           versions=[67] network=42 dbversion=
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.545] Loading Last State: 0
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.545] Loaded most recent local header          number=0 hash=9195f2..122dcd td=1 age=54y3mo5d
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.545] Loaded most recent local full block      number=0 hash=9195f2..122dcd td=1 age=54y3mo5d
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.545] Loaded most recent local fast block      number=0 hash=9195f2..122dcd td=1 age=54y3mo5d
test_cmd.go:262: (stderr:33) WARN [06-27|13:02:23.545] Failed to load snapshot, regenerating    err="missing or corrupted snapshot"
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.545] Rebuilding state snapshot
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.545] Journalled generator progress            progress=empty
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.545] Start snapshot generation                root=8a7a77..f86ff6
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.545] Resuming state snapshot generation       root=8a7a77..f86ff6 accounts=0 slots=0 storage=0.00B elapsed="504.365µs"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.546] Regenerated state range                  kind=storage prefix=0x6fc8292a2675fd2df398d2f757c44afe1b96e4c7ba26dac7ed67cdef77799ef404 root=09f508..8cb885 last=0x count=1 created=1 updated=0 untouched=0 deleted=0
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.546] Regenerated state range                  kind=account prefix=0x61 root=8a7a77..f86ff6 last=0x count=2 created=2 updated=0 untouched=0 deleted=0
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.546] Journalled generator progress            progress=done
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.546] Generated state snapshot                 accounts=2 slots=1 storage=230.00B elapsed="873.361µs"
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.546] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd9272338b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37 maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.546] Registry contract not yet deployed       function=blockGasLimit registryId=0x8b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.546] Error calling blockGasLimit              err="Registry not deployed"         contract=0x8b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.546] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd92723348766a30bcca8b3c8b03b4e4b1f6510aee73f7b41aa6c7578a97040d20334f42 maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.546] Registry contract not yet deployed       function=gasPriceMinimumFloor registryId=0x48766a30bcca8b3c8b03b4e4b1f6510aee73f7b41aa6c7578a97040d20334f42
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.546] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd9272338b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37 maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.546] Registry contract not yet deployed       function=intrinsicGasForAlternativeFeeCurrency registryId=0x8b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.547] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd9272338f897d9543fdc9082789208180c3e3d11f7473aaef3e249ab0020ea0c761c1b6 maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.547] Registry contract not yet deployed       function=getWhitelist                          registryId=0x8f897d9543fdc9082789208180c3e3d11f7473aaef3e249ab0020ea0c761c1b6
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.547] getWhitelist invocation failed           err="Registry not deployed"
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.547] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd927233d7e89ade8430819f08bf97a087285824af3351ee12d72a2d132b0c6c0687bfaf maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.547] Reinjecting stale transactions           count=0
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.547] Regenerated local transaction journal    transactions=0 accounts=0
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.568] Allocated fast sync bloom                size=512.00MiB
test_cmd.go:262: (stderr:33) WARN [06-27|13:02:23.569] Error reading unclean shutdown markers   error="leveldb: not found"
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.569] Allocated cache and file handles         database=/tmp/geth-test2641949100/celo/les.server cache=16.00MiB  handles=16
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.577] Initialized state bloom                  items=5 errorrate=0.000 elapsed=8.680ms
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.586] Checkpoint oracle is not enabled
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.586] Starting peer-to-peer node               instance=celo/v1.6.0-unstable/linux-amd64/go1.17.5
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.595] TCP listener up                          addr=[::]:40229
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.595] Mapped network port                      proto=tcp extport=40229 intport=40229 interface=ExtIP(127.0.0.1)
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.596] IPCs registered                          namespaces=admin,debug,web3,eth,txpool,personal,istanbul,miner,net,les
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.596] IPC endpoint opened                      url=/tmp/geth-test2641949100/geth-1.ipc
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.597] New local node record                    seq=1,687,870,943,595 id=e3929132a3a51fd7 ip=127.0.0.1 udp=0 tcp=40229
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.597] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd927233235a6f54090e9b94aa4e585a699c4375a2ff8f572c68114d138f0ed121527849 maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.597] Registry contract not yet deployed       function=getElectableValidators                registryId=0x235a6f54090e9b94aa4e585a699c4375a2ff8f572c68114d138f0ed121527849
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.597] Snapshot is nil, creating from genesis
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.597] Started P2P networking                   self="enode://0a9622ebf3a76ff54125ccbca9eb4180bea8b213e7e7d05d2be4027e66889217314c46940d529890350172fa17cc461d798b966deb69737bed724a8bc2cb0edf@127.0.0.1:40229?discport=0" maxdialed=58 maxinbound=118
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.691] Unlocked account                         address=0x02F0d131F1f97aef08aEc6E3291B957d9Efe7105
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.691] Starting istanbul.Engine validating
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.691] Open roundstate db                       func=newRoundStateDB type=roundStateDB rsdb_path=/tmp/geth-test2641949100/celo/roundstates
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.691] NewWork called, acquiring core lock      func=NewWork
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.707] Creating new RoundState                  address=0x02F0d131F1f97aef08aEc6E3291B957d9Efe7105 func=createRoundState cur_seq=0 cur_epoch=0 cur_round=-1 des_round=-1 state="Accept request" address=0x02F0d131F1f97aef08aEc6E3291B957d9Efe7105 reason="No storedView found"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.707] Posting FinalCommittedEvent              func=NewWork
test_cmd.go:262: (stderr:33) WARN [06-27|13:02:23.708] New sequence should be larger than current sequence address=0x02F0d131F1f97aef08aEc6E3291B957d9Efe7105 func=startNewSequence tag=stateTransition head_block=0 head_block_hash=9195f2..122dcd cur_seq=1 cur_epoch=1 cur_round=0  des_round=0  state="Accept request" address=0x02F0d131F1f97aef08aEc6E3291B957d9Efe7105
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.708] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd9272338b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37 maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.708] Registry contract not yet deployed       function=blockGasLimit                         registryId=0x8b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.708] Error calling blockGasLimit              err="Registry not deployed"         contract=0x8b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.708] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd9272338b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37 maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.708] Registry contract not yet deployed       function=intrinsicGasForAlternativeFeeCurrency registryId=0x8b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.708] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd9272338f897d9543fdc9082789208180c3e3d11f7473aaef3e249ab0020ea0c761c1b6 maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.708] Registry contract not yet deployed       function=getWhitelist                          registryId=0x8f897d9543fdc9082789208180c3e3d11f7473aaef3e249ab0020ea0c761c1b6
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.708] getWhitelist invocation failed           err="Registry not deployed"
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.708] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd927233d7e89ade8430819f08bf97a087285824af3351ee12d72a2d132b0c6c0687bfaf maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.708] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd92723302dfe2d0485b616b61db1800f30f4a14b26754b328fa09ba4ec73ee7276766cc maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.708] Registry address lookup failed           err="Registry not deployed"         contract=0x02dfe2d0485b616b61db1800f30f4a14b26754b328fa09ba4ec73ee7276766cc
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.708] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd927233d7e89ade8430819f08bf97a087285824af3351ee12d72a2d132b0c6c0687bfaf maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.708] Registry contract not yet deployed       function=totalSupply                           registryId=0xd7e89ade8430819f08bf97a087285824af3351ee12d72a2d132b0c6c0687bfaf
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.708] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd9272338b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37 maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.708] Registry contract not yet deployed       function=blockGasLimit                         registryId=0x8b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.708] Error calling blockGasLimit              err="Registry not deployed"         contract=0x8b91d837e1684f7353d73b6197230894243cf869282f722841df96b441303f37
test_cmd.go:262: (stderr:33) ERROR[06-27|13:02:23.708] Error invoking evm function: EVM call failure to=0x000000000000000000000000000000000000ce10 method=getAddressFor input=0xdd92723348766a30bcca8b3c8b03b4e4b1f6510aee73f7b41aa6c7578a97040d20334f42 maxgas=100,000 err="execution reverted"            message="No Implementation set"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.708] Registry contract not yet deployed       function=updateGasPriceMinimum                 registryId=0x48766a30bcca8b3c8b03b4e4b1f6510aee73f7b41aa6c7578a97040d20334f42
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:23.708] Finalized                                func=Finalize         block=1 epochSize=30000 duration="209.894µs" lastInEpoch=false
test_cmd.go:262: (stderr:33) WARN [06-27|13:02:23.708] Block sealing failed                     err="not an elected validator"
test_cmd.go:262: (stderr:33) INFO [06-27|13:02:23.708] Commit new mining work                   number=1 txs=0 gas=0 fees=0 elapsed="940.223µs"
les_test.go:121: Initializing geth: [--networkid=42 init ./testdata/clique.json]
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.926] Maximum peer count                       ETH=175 LES=0 total=175
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.927] Set global gas inflation rate            rate=1.300
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.927] Set global gas cap                       cap=25,000,000
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.927] Allocated cache and file handles         database=/tmp/geth-test433644007/celo/chaindata cache=16.00MiB handles=16
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.963] Writing custom genesis block
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.964] Persisted trie from memory database      nodes=4 size=566.00B time="76.748µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=-82.00B
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.964] Successfully wrote genesis state         database=chaindata                              hash=9195f2..122dcd
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.964] Allocated cache and file handles         database=/tmp/geth-test433644007/celo/lightchaindata cache=16.00MiB handles=16
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.976] Writing custom genesis block
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.976] Persisted trie from memory database      nodes=4 size=566.00B time="32.698µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=-82.00B
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.976] Successfully wrote genesis state         database=lightchaindata                         hash=9195f2..122dcd
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.977] Allocated cache and file handles         database=/tmp/geth-test433644007/celo/lightestchaindata cache=16.00MiB handles=16
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.987] Writing custom genesis block
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.987] Persisted trie from memory database      nodes=4 size=566.00B time="36.552µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=-82.00B
test_cmd.go:262: (stderr:34) INFO [06-27|13:02:23.988] Successfully wrote genesis state         database=lightestchaindata                      hash=9195f2..122dcd
les_test.go:99: Starting freeCli with rpc: [--networkid=42 --port=0 --ipcpath geth-2.ipc --datadir /tmp/geth-test433644007 --nodiscover --syncmode=light --nat=extip:127.0.0.1 --verbosity=4]
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.023] Dropping default light client cache      provided=1024 updated=128
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.024] Maximum peer count                       ETH=0 LES=10 total=175
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.025] FS scan times                            list="39.715µs" set=335ns diff="1.028µs"
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.025] Sanitizing Go's GC trigger               percent=100
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.025] Set global gas inflation rate            rate=1.300
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.025] Set global gas cap                       cap=25,000,000
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.031] Allocated cache and file handles         database=/tmp/geth-test433644007/celo/lightchaindata cache=64.00MiB handles=524,288
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.046] Allocated cache and file handles         database=/tmp/geth-test433644007/celo/les.client cache=16.00MiB handles=16
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.060] Initialised chain configuration          config="{ChainID: 15 Homestead: 0 DAO:  DAOSupport: false EIP150: 0 EIP155: 0 EIP158: 0 Byzantium: 0 Constantinople: 0 Petersburg: 0 Istanbul:  Churrito: , Donut: , Espresso: , Gingerbread: , Engine: istanbul}"
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.060] Setting up Istanbul consensus engine
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.091] Loaded most recent local header          number=0 hash=9195f2..122dcd td=1 age=54y3mo5d
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.091] Checkpoint oracle is not enabled
test_cmd.go:262: (stderr:35) WARN [06-27|13:02:24.091] Error reading unclean shutdown markers   error="leveldb: not found"
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.091] Starting peer-to-peer node               instance=celo/v1.6.0-unstable/linux-amd64/go1.17.5
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.108] Mapped network port                      proto=tcp extport=46433 intport=46433 interface=ExtIP(127.0.0.1)
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.108] TCP listener up                          addr=[::]:46433
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.110] IPCs registered                          namespaces=admin,debug,web3,eth,txpool,personal,istanbul,les,net,vflux
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.110] IPC endpoint opened                      url=/tmp/geth-test433644007/geth-2.ipc
test_cmd.go:262: (stderr:35) WARN [06-27|13:02:24.110] Light client mode is an experimental feature
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.110] New local node record                    seq=1,687,870,944,109 id=fad9bda7737527b4 ip=127.0.0.1 udp=0 tcp=46433
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.110] Started P2P networking                   self="enode://838234d786aafc1698f7f26bc82103ac6be600c209143ba3c546692cc98ca587ba6ca6829076451f780d53b68445d45a8857ba94e4409837acb74af3d215441c@127.0.0.1:46433?discport=0" maxdialed=58 maxinbound=117
les_test.go:37: freeCli.addPeer(lightserver)
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:24.493] Served admin_nodeInfo                    reqid=1 t="382.993µs"
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.493] Served admin_subscribe                   reqid=1 t="74.411µs"
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.494] Served admin_addPeer                     reqid=2 t="196.285µs"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:24.497] Adding p2p peer                          peercount=1 id=fad9bda7737527b4 conn=inbound addr=127.0.0.1:58138 name=celo/v1.6.0-unstable...
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:24.497] Light Ethereum peer connected            id=fad9bda7737527b4 conn=inbound name=celo/v1.6.0-unstable...
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:24.497] Light Ethereum handshake failed          id=fad9bda7737527b4 conn=inbound err="Cannot serve old clients without a complete tx index"
test_cmd.go:262: (stderr:33) DEBUG[06-27|13:02:24.497] Removing p2p peer                        peercount=0 id=fad9bda7737527b4 duration="275.504µs" req=false err="Cannot serve old clients without a complete tx index"
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.497] Adding p2p peer                          peercount=1 id=e3929132a3a51fd7 conn=staticdial addr=127.0.0.1:40229 name=celo/v1.6.0-unstable...
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.497] Light Ethereum peer connected            id=e3929132a3a51fd7 conn=staticdial name=celo/v1.6.0-unstable...
les_test.go:50: freeCli received event: type=add, peer=e3929132a3a51fd7c8493c042750a588861aec38f9583fde03c064ba11f61e13
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.498] Served admin_unsubscribe                 reqid=3 t="55.584µs"
test_cmd.go:262: (stderr:35) INFO [06-27|13:02:24.498] Disconnecting from static or trusted peer id=e3929132a3a51fd7 conn=staticdial purpose=ExplicitStaticPurpose reason="disconnect requested" remoteRequested=true err="disconnect requested"
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.498] Light Ethereum handshake failed          id=e3929132a3a51fd7 conn=staticdial err=EOF
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.498] Removing p2p peer                        peercount=0 id=e3929132a3a51fd7 duration=1.324ms req=true err="disconnect requested"
test_cmd.go:262: (stderr:35) DEBUG[06-27|13:02:24.498] Served admin_peers                       reqid=4 t="144.374µs"
les_test.go:156: Expected: # of client peers == 1, actual: 0
  TestGetBlockHeadersLes4: les
/runner/_work/celo-blockchain/celo-blockchain/les/costtracker.go:485
/runner/_work/celo-blockchain/celo-blockchain/les/server_handler.go:208 +0x13d
/runner/_work/celo-blockchain/celo-blockchain/les/server_handler.go:320 +0x52c
/runner/_work/celo-blockchain/celo-blockchain/les/server_handler.go:187 +0xb46
/runner/_work/celo-blockchain/celo-blockchain/les/test_helper.go:533 +0x53
/runner/_work/celo-blockchain/celo-blockchain/les/test_helper.go:529 +0x2f4
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.29 :tada:

Comparison is base (4bd05de) 55.27% compared to head (d8b3680) 55.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2143 +/- ## ========================================== + Coverage 55.27% 55.57% +0.29% ========================================== Files 675 647 -28 Lines 113730 107663 -6067 ========================================== - Hits 62869 59837 -3032 + Misses 47009 44220 -2789 + Partials 3852 3606 -246 ``` [see 50 files with indirect coverage changes](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2143/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

palango commented 1 year ago

There's a problem with how older LES protocols handle transaction pruning, so we cannot remove them like this.