search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

Revert "Cleanup/tx processing (#2102)" #2145

Closed hbandura closed 1 year ago

hbandura commented 1 year ago

This reverts commit c8843c1c80910494dba8d7075213fa2933ccd91e. #2102 made a change in the state_transition that ended up forking mainnet blocks. We can re-create the cleanup in smaller chunks afterwards, to avoid this problem.

github-actions[bot] commented 1 year ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit e10394dfcaef2825ca799c97ddea3d3e78593724

coverage: 49.1% of statements across all listed packages 
coverage:  60.2% of statements in consensus/istanbul
coverage:  43.1% of statements in consensus/istanbul/announce
coverage:  55.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  60.1% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 1 year ago

5839 passed, 2 failed, 45 skipped

Test failures:
  TestPriorityClient: geth
    les_test.go:121: Initializing geth: [--networkid=42 init ./testdata/clique.json]
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.836] Maximum peer count                       ETH=175 LES=0 total=175
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.838] Set global gas inflation rate            rate=1.300
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.838] Set global gas cap                       cap=25,000,000
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.838] Allocated cache and file handles         database=/tmp/geth-test2251067437/celo/chaindata cache=16.00MiB handles=16
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.856] Writing custom genesis block
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.857] Persisted trie from memory database      nodes=4 size=566.00B time="63.845µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=-82.00B
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.857] Successfully wrote genesis state         database=chaindata                               hash=9195f2..122dcd
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.857] Allocated cache and file handles         database=/tmp/geth-test2251067437/celo/lightchaindata cache=16.00MiB handles=16
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.867] Writing custom genesis block
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.867] Persisted trie from memory database      nodes=4 size=566.00B time="29.371µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=-82.00B
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.868] Successfully wrote genesis state         database=lightchaindata                          hash=9195f2..122dcd
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.868] Allocated cache and file handles         database=/tmp/geth-test2251067437/celo/lightestchaindata cache=16.00MiB handles=16
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.876] Writing custom genesis block
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.876] Persisted trie from memory database      nodes=4 size=566.00B time="27.779µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=-82.00B
test_cmd.go:262: (stderr:31) INFO [07-03|08:44:42.877] Successfully wrote genesis state         database=lightestchaindata                       hash=9195f2..122dcd
les_test.go:130: Importing keys to geth
test_cmd.go:262: (stderr:32) INFO [07-03|08:44:42.912] Maximum peer count                       ETH=175 LES=0 total=175
test_cmd.go:262: (stderr:32) INFO [07-03|08:44:42.913] Set global gas inflation rate            rate=1.300
test_cmd.go:262: (stderr:32) INFO [07-03|08:44:42.913] Set global gas cap                       cap=25,000,000
les_test.go:99: Starting lightserver with rpc: [--networkid=42 --port=0 --ipcpath geth-1.ipc --allow-insecure-unlock --datadir /tmp/geth-test2251067437 --password ./testdata/password.txt --unlock 0x02f0d131f1f97aef08aec6e3291b957d9efe7105 --mine --miner.validator 0x02f0d131f1f97aef08aec6e3291b957d9efe7105 --tx-fee-recipient 0x02f0d131f1f97aef08aec6e3291b957d9efe7105 --light.serve=100 --light.maxpeers=1 --nodiscover --nat=extip:127.0.0.1 --verbosity=4]
test_cmd.go:262: (stderr:33) INFO [07-03|08:44:43.322] Maximum peer count                       ETH=175 LES=1 total=176
test_cmd.go:262: (stderr:33) DEBUG[07-03|08:44:43.363] FS scan times                            list=39.87675ms set="9.554µs" diff="2.945µs"
test_cmd.go:262: (stderr:33) WARN [07-03|08:44:43.363] LES server cannot serve old transaction status and cannot connect below les/4 protocol version if transaction lookup index is limited
test_cmd.go:262: (stderr:33) DEBUG[07-03|08:44:43.363] Sanitizing Go's GC trigger               percent=100
test_cmd.go:262: (stderr:33) INFO [07-03|08:44:43.363] Set global gas inflation rate            rate=1.300
test_cmd.go:262: (stderr:33) INFO [07-03|08:44:43.363] Set global gas cap                       cap=25,000,000
test_cmd.go:262: (stderr:33) INFO [07-03|08:44:43.363] Allocated trie memory caches             clean=154.00MiB dirty=256.00MiB
test_cmd.go:262: (stderr:33) INFO [07-03|08:44:43.363] Allocated cache and file handles         database=/tmp/geth-test2251067437/celo/chaindata cache=512.00MiB handles=524,288
test_cmd.go:262: (stderr:33) DEBUG[07-03|08:44:43.992] Chain freezer table opened               database=/tmp/geth-test2251067437/celo/chaindata/ancient table=receipts items=0 size=0.00B
test_cmd.go:262: (stderr:33) DEBUG[07-03|08:44:44.176] Chain freezer table opened               database=/tmp/geth-test2251067437/celo/chaindata/ancient table=diffs    items=0 size=0.00B
test_cmd.go:262: (stderr:33) DEBUG[07-03|08:44:44.660] Chain freezer table opened               database=/tmp/geth-test2251067437/celo/chaindata/ancient table=headers  items=0 size=0.00B
test_cmd.go:262: (stderr:33) DEBUG[07-03|08:44:44.701] Chain freezer table opened               database=/tmp/geth-test2251067437/celo/chaindata/ancient table=hashes   items=0 size=0.00B
test_cmd.go:262: (stderr:33) DEBUG[07-03|08:44:45.163] Chain freezer table opened               database=/tmp/geth-test2251067437/celo/chaindata/ancient table=bodies   items=0 size=0.00B
test_cmd.go:262: (stderr:33) INFO [07-03|08:44:45.163] Opened ancient database                  database=/tmp/geth-test2251067437/celo/chaindata/ancient readonly=false
test_cmd.go:262: (stderr:33) DEBUG[07-03|08:44:45.163] Current full block not old enough        number=0 hash=9195f2..122dcd delay=90000
test_cmd.go:262: (stderr:33) INFO [07-03|08:44:45.164] Initialised chain configuration          config="{ChainID: 15 Homestead: 0 DAO:  DAOSupport: false EIP150: 0 EIP155: 0 EIP158: 0 Byzantium: 0 Constantinople: 0 Petersburg: 0 Istanbul:  Churrito: , Donut: , Espresso: , Gingerbread: , Engine: istanbul}"
test_cmd.go:262: (stderr:33) DEBUG[07-03|08:44:45.164] Setting up Istanbul consensus engine
les_test.go:115: lightserver rpc connect to /tmp/geth-test2251067437/geth-1.ipc: dial unix /tmp/geth-test2251067437/geth-1.ipc: connect: no such file or directory
  TestTransactionIndices: core
    blockchain_test.go:1944: Oldest indexded block mismatch, want 100, have 67
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.