search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

Improve error logging in toCeloFn #2157

Closed karlb closed 1 year ago

karlb commented 1 year ago

This might help us debug https://github.com/celo-org/celo-blockchain/issues/2134 if it happens again.

github-actions[bot] commented 1 year ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit b1bba65211f9808399c6c1802520978d78ff1777

coverage: 48.9% of statements across all listed packages 
coverage:  63.0% of statements in consensus/istanbul
coverage:  40.5% of statements in consensus/istanbul/announce
coverage:  54.5% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  61.0% of statements in consensus/istanbul/core
coverage:  45.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 1 year ago

5855 passed, 1 failed, 45 skipped

Test failures:
  TestBlockTracingConcurrentMapAccess: e2e_test
Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000  denominator = 1000000000000000000000000
Checking gas price minimum. cusdValue = 100000000
e2e_test.go:396:
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.01 :tada:

Comparison is base (4860e01) 55.17% compared to head (a10ae25) 55.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2157 +/- ## ========================================== + Coverage 55.17% 55.18% +0.01% ========================================== Files 673 676 +3 Lines 113208 113888 +680 ========================================== + Hits 62458 62849 +391 - Misses 46915 47175 +260 - Partials 3835 3864 +29 ``` | [Impacted Files](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | Coverage Δ | | |---|---|---| | [miner/block.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-bWluZXIvYmxvY2suZ28=) | `52.67% <25.00%> (ø)` | | | [contracts/currency/currency.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29udHJhY3RzL2N1cnJlbmN5L2N1cnJlbmN5Lmdv) | `55.00% <100.00%> (ø)` | | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2157/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.