search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

tests: Remove unused storage maps #2165

Closed palango closed 1 year ago

palango commented 1 year ago

Small cleanup.

github-actions[bot] commented 1 year ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 84ca735093e078116fbca9049f80b55f4c2289be

coverage: 49.4% of statements across all listed packages 
coverage:  59.8% of statements in consensus/istanbul
coverage:  43.1% of statements in consensus/istanbul/announce
coverage:  55.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  60.9% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 1 year ago

5846 passed, 3 failed, 45 skipped

Test failures:
  TestTransferCELOPreGingerbread: e2e_test
Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000  denominator = 1000000000000000000000000
Checking gas price minimum. cusdValue = 100000000
e2e_transfer_test.go:257:
  TestEthClient: ethclient
INFO [07-26|13:44:19.629] Persisted trie from memory database      nodes=1 size=146.00B time="36.22µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=0.00B
INFO [07-26|13:44:19.634] Allocated trie memory caches             clean=0.00B dirty=0.00B
WARN [07-26|13:44:19.634] Sanitizing invalid gateway fee           provided= updated=0
INFO [07-26|13:44:19.634] Writing custom genesis block 
INFO [07-26|13:44:19.634] Persisted trie from memory database      nodes=1 size=146.00B time="6.923µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=0.00B
INFO [07-26|13:44:19.634] Initialised chain configuration          config="{ChainID: 1337 Homestead: 0 DAO:  DAOSupport: false EIP150: 0 EIP155: 0 EIP158: 0 Byzantium: 0 Constantinople: 0 Petersburg: 0 Istanbul: 0 Churrito: 0, Donut: 0, Espresso: 0, Gingerbread: 0, Engine: MockEngine}"
INFO [07-26|13:44:19.634] Initialising Ethereum protocol           versions=[67] network=0 dbversion=
INFO [07-26|13:44:19.635] Loaded most recent local header          number=0 hash=0f9636..27f64f td=1 age=54y4mo4d
INFO [07-26|13:44:19.635] Loaded most recent local full block      number=0 hash=0f9636..27f64f td=1 age=54y4mo4d
INFO [07-26|13:44:19.635] Loaded most recent local fast block      number=0 hash=0f9636..27f64f td=1 age=54y4mo4d
WARN [07-26|13:44:19.635] Sanitizing invalid txpool journal time   provided=0s    updated=1s
WARN [07-26|13:44:19.635] Sanitizing invalid txpool price bump     provided=0     updated=10
WARN [07-26|13:44:19.635] Sanitizing invalid txpool account slots  provided=0     updated=16
WARN [07-26|13:44:19.635] Sanitizing invalid txpool global slots   provided=0     updated=5120
WARN [07-26|13:44:19.635] Sanitizing invalid txpool account queue  provided=0     updated=64
WARN [07-26|13:44:19.635] Sanitizing invalid txpool global queue   provided=0     updated=1024
WARN [07-26|13:44:19.635] Sanitizing invalid txpool lifetime       provided=0s    updated=3h0m0s
ERROR[07-26|13:44:19.635] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.636] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.636] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.636] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.636] getWhitelist invocation failed           err="Registry not deployed"
WARN [07-26|13:44:19.638] Error reading unclean shutdown markers   error="not found"
INFO [07-26|13:44:19.638] Starting peer-to-peer node               instance=ethclient.test/linux-amd64/go1.18.10
INFO [07-26|13:44:19.655] New local node record                    seq=1,690,379,059,654 id=d5314d5c13ea93fd ip=127.0.0.1 udp=36836 tcp=0
INFO [07-26|13:44:19.656] Started P2P networking                   self="enode://566abb5b6e1e2f4060bf18e870d2c2f33a4c9ac86b8a20cc1fa6b5dc16688f08c6c74116ae4411c5cc94df4eef98fa41732a8966a95298deffd3abbccda8ce2a@127.0.0.1:0?discport=36836" maxdialed=0 maxinbound=0
ERROR[07-26|13:44:19.656] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.656] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.656] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.656] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.656] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.656] getWhitelist invocation failed           err="Registry not deployed"
INFO [07-26|13:44:19.656] Imported new chain segment               blocks=1 txs=0 mgas=0.000 elapsed="982.06µs" mgasps=0.000 number=1 hash=39401a..57383c age=54y4mo4d dirty=686.00B
  TestEthClient/TestTxInBlockInterrupted: ethclient
ERROR[07-26|13:44:19.656] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.657] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.657] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.657] getWhitelist invocation failed           err="Registry not deployed"
ERROR[07-26|13:44:19.657] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.657] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.657] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.657] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[07-26|13:44:19.657] getWhitelist invocation failed           err="Registry not deployed"
    ethclient_test.go:382: error should not be nil/notfound
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.02% :warning:

Comparison is base (cc4fc1a) 55.17% compared to head (112d6c2) 55.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2165 +/- ## ========================================== - Coverage 55.17% 55.16% -0.02% ========================================== Files 676 676 Lines 113991 113991 ========================================== - Hits 62900 62883 -17 - Misses 47218 47237 +19 + Partials 3873 3871 -2 ``` [see 24 files with indirect coverage changes](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2165/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.