search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

Celo Dynamic Fee V2 #2170

Closed gastonponti closed 1 year ago

gastonponti commented 1 year ago

Description

Celo dynamic fee v2 implements the CIP (https://github.com/celo-org/celo-proposals/discussions/393)

Backwards compatibility

Part of the Gingerbread Hard Fork

github-actions[bot] commented 1 year ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit b7893f5bfbf12ef30ba99dc5866248b7110d76e2

coverage: 50.4% of statements across all listed packages 
coverage:  62.8% of statements in consensus/istanbul
coverage:  42.7% of statements in consensus/istanbul/announce
coverage:  55.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  63.9% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 1 year ago

5861 passed, 1 failed, 45 skipped

Test failures:
  TestEthersJSCompatibility: e2e_test
Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000  denominator = 1000000000000000000000000
Checking gas price minimum. cusdValue = 100000000
executing mocha test with /usr/bin/npm run --networkaddr=http://127.0.0.1:35573 test --blocknum=0x0 -- --grep ethers.js compatibility tests with state




ethersjs-api-check@1.0.0 test /runner/_work/celo-blockchain/celo-blockchain/e2e_test/ethersjs-api-check
mocha -r ts-node/register test/*.ts "--grep" "ethers.js compatibility tests with state"




ethers.js compatibility tests with state
✔ provider.getBlock works (block has gasLimit set) (50ms)
✔ EIP-1559 transactions supported (can get feeData)
✔ block has gasLimit
1) block has baseFeePerGas


3 passing (117ms)
1 failing


1) ethers.js compatibility tests with state
block has baseFeePerGas:


  AssertionError: expected false to be true
  + expected - actual

  -false
  +true

  at /runner/_work/celo-blockchain/celo-blockchain/e2e_test/ethersjs-api-check/test/test.ts:52:10
  at Generator.next (<anonymous>)
  at fulfilled (test/test.ts:5:58)
  at processTicksAndRejections (internal/process/task_queues.js:95:5)


npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! ethersjs-api-check@1.0.0 test: mocha -r ts-node/register test/*.ts "--grep" "ethers.js compatibility tests with state"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the ethersjs-api-check@1.0.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.


npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-08-17T19_03_18_974Z-debug.log


e2e_test.go:685: </code></pre></td></tr>
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 20.86% and project coverage change: +0.08% :tada:

Comparison is base (0404e7a) 55.15% compared to head (3a0f1c1) 55.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2170 +/- ## ========================================== + Coverage 55.15% 55.24% +0.08% ========================================== Files 676 677 +1 Lines 114015 114252 +237 ========================================== + Hits 62887 63114 +227 - Misses 47248 47274 +26 + Partials 3880 3864 -16 ``` | [Files Changed](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | Coverage Δ | | |---|---|---| | [common/types.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29tbW9uL3R5cGVzLmdv) | `58.52% <0.00%> (-0.55%)` | :arrow_down: | | [core/state\_processor.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29yZS9zdGF0ZV9wcm9jZXNzb3IuZ28=) | `81.34% <0.00%> (-1.87%)` | :arrow_down: | | [core/types/celo\_dynamic\_fee\_tx.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29yZS90eXBlcy9jZWxvX2R5bmFtaWNfZmVlX3R4Lmdv) | `1.53% <0.00%> (ø)` | | | [internal/ethapi/transaction\_args.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-aW50ZXJuYWwvZXRoYXBpL3RyYW5zYWN0aW9uX2FyZ3MuZ28=) | `0.00% <0.00%> (ø)` | | | [light/txpool.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-bGlnaHQvdHhwb29sLmdv) | `39.34% <0.00%> (-2.04%)` | :arrow_down: | | [core/types/celo\_dynamic\_fee\_tx\_v2.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29yZS90eXBlcy9jZWxvX2R5bmFtaWNfZmVlX3R4X3YyLmdv) | `1.66% <1.66%> (ø)` | | | [core/types/transaction\_marshalling.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29yZS90eXBlcy90cmFuc2FjdGlvbl9tYXJzaGFsbGluZy5nbw==) | `23.90% <2.70%> (-5.70%)` | :arrow_down: | | [core/types/receipt.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29yZS90eXBlcy9yZWNlaXB0Lmdv) | `34.76% <25.00%> (-0.46%)` | :arrow_down: | | [core/types/transaction\_signing.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29yZS90eXBlcy90cmFuc2FjdGlvbl9zaWduaW5nLmdv) | `57.73% <36.53%> (-4.83%)` | :arrow_down: | | [internal/ethapi/api.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-aW50ZXJuYWwvZXRoYXBpL2FwaS5nbw==) | `4.31% <41.17%> (+0.42%)` | :arrow_up: | | ... and [8 more](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | | ... and [31 files with indirect coverage changes](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2170/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.