search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

Block size limit #2174

Closed gastonponti closed 1 year ago

gastonponti commented 1 year ago

Description

Block size limit CIP implementation of https://github.com/celo-org/celo-proposals/discussions/394 (number to be assigned)

Backwards compatibility

Part of the Gingerbread Part 2 Hard Fork

github-actions[bot] commented 1 year ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit edbf300bbac9774edca2d856e09b10d88cb018ef

coverage: 49.5% of statements across all listed packages 
coverage:  63.2% of statements in consensus/istanbul
coverage:  41.8% of statements in consensus/istanbul/announce
coverage:  55.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  61.0% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 1 year ago

5861 passed, 1 failed, 45 skipped

Test failures:
  TestEthersJSCompatibility: e2e_test
Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000  denominator = 1000000000000000000000000
Checking gas price minimum. cusdValue = 100000000
executing mocha test with /usr/bin/npm run --networkaddr=http://127.0.0.1:40775 test --blocknum=0x0 -- --grep ethers.js compatibility tests with state




ethersjs-api-check@1.0.0 test /runner/_work/celo-blockchain/celo-blockchain/e2e_test/ethersjs-api-check
mocha -r ts-node/register test/*.ts "--grep" "ethers.js compatibility tests with state"




ethers.js compatibility tests with state
✔ provider.getBlock works (block has gasLimit set)
✔ EIP-1559 transactions supported (can get feeData)
✔ block has gasLimit
1) block has baseFeePerGas


3 passing (89ms)
1 failing


1) ethers.js compatibility tests with state
block has baseFeePerGas:


  AssertionError: expected false to be true
  + expected - actual

  -false
  +true

  at /runner/_work/celo-blockchain/celo-blockchain/e2e_test/ethersjs-api-check/test/test.ts:52:10
  at Generator.next (<anonymous>)
  at fulfilled (test/test.ts:5:58)
  at processTicksAndRejections (internal/process/task_queues.js:95:5)


npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! ethersjs-api-check@1.0.0 test: mocha -r ts-node/register test/*.ts "--grep" "ethers.js compatibility tests with state"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the ethersjs-api-check@1.0.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.


npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-08-17T23_11_36_295Z-debug.log


e2e_test.go:685: </code></pre></td></tr>
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 60.00% and no project coverage change.

Comparison is base (b7893f5) 55.10% compared to head (755a9be) 55.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2174 +/- ## ======================================= Coverage 55.10% 55.10% ======================================= Files 677 678 +1 Lines 114252 114297 +45 ======================================= + Hits 62958 62988 +30 - Misses 47411 47419 +8 - Partials 3883 3890 +7 ``` | [Files Changed](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | Coverage Δ | | |---|---|---| | [consensus/istanbul/backend/backend.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29uc2Vuc3VzL2lzdGFuYnVsL2JhY2tlbmQvYmFja2VuZC5nbw==) | `53.67% <20.00%> (-0.24%)` | :arrow_down: | | [miner/block.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-bWluZXIvYmxvY2suZ28=) | `52.00% <38.46%> (-0.68%)` | :arrow_down: | | [core/bytesblock.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29yZS9ieXRlc2Jsb2NrLmdv) | `60.00% <60.00%> (ø)` | | | [core/block\_validator.go](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-Y29yZS9ibG9ja192YWxpZGF0b3IuZ28=) | `64.70% <100.00%> (+10.85%)` | :arrow_up: | ... and [23 files with indirect coverage changes](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2174/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.