celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

Refactor build-sign-release-images workflow #2200

Closed jcortejoso closed 11 months ago

jcortejoso commented 11 months ago

Description

Refactor the GitHub workflow for celo-blockchain release images:

Tested manually. The tagged releases (i.e. with tag v1.8.0) could not be tested because the security contraints require that the tag created follow the pattern vx.y.z, and I did not want to create a fake release for testing.

github-actions[bot] commented 11 months ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit f6cfb3a089ff2d89b458140be02fd08f3caf79a9

coverage: 48.9% of statements across all listed packages
coverage:  63.0% of statements in consensus/istanbul
coverage:  40.0% of statements in consensus/istanbul/announce
coverage:  54.6% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  61.1% of statements in consensus/istanbul/core
coverage:  45.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.2% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 11 months ago

5869 passed, 2 failed, 45 skipped

Test failures:
  TestEthClient: ethclient
INFO [10-26|14:19:23.090] Persisted trie from memory database      nodes=1 size=146.00B time="14.962µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=0.00B
INFO [10-26|14:19:23.092] Allocated trie memory caches             clean=0.00B dirty=0.00B
WARN [10-26|14:19:23.092] Sanitizing invalid gateway fee           provided= updated=0
INFO [10-26|14:19:23.092] Writing custom genesis block
INFO [10-26|14:19:23.092] Persisted trie from memory database      nodes=1 size=146.00B time="11.333µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=0.00B
INFO [10-26|14:19:23.093] Initialised chain configuration          config="{ChainID: 1337 Homestead: 0 DAO:  DAOSupport: false EIP150: 0 EIP155: 0 EIP158: 0 Byzantium: 0 Constantinople: 0 Petersburg: 0 Istanbul: 0 Churrito: 0, Donut: 0, Espresso: 0, Gingerbread: 0, Gingerbread P2: 0, Engine: MockEngine}"
INFO [10-26|14:19:23.093] Initialising Ethereum protocol           versions=[67] network=0 dbversion=
INFO [10-26|14:19:23.093] Loaded most recent local header          number=0 hash=0f9636..27f64f td=1 age=54y7mo6d
INFO [10-26|14:19:23.093] Loaded most recent local full block      number=0 hash=0f9636..27f64f td=1 age=54y7mo6d
INFO [10-26|14:19:23.093] Loaded most recent local fast block      number=0 hash=0f9636..27f64f td=1 age=54y7mo6d
WARN [10-26|14:19:23.093] Sanitizing invalid txpool journal time   provided=0s    updated=1s
WARN [10-26|14:19:23.093] Sanitizing invalid txpool price bump     provided=0     updated=10
WARN [10-26|14:19:23.093] Sanitizing invalid txpool account slots  provided=0     updated=16
WARN [10-26|14:19:23.093] Sanitizing invalid txpool global slots   provided=0     updated=5120
WARN [10-26|14:19:23.093] Sanitizing invalid txpool account queue  provided=0     updated=64
WARN [10-26|14:19:23.093] Sanitizing invalid txpool global queue   provided=0     updated=1024
WARN [10-26|14:19:23.093] Sanitizing invalid txpool lifetime       provided=0s    updated=3h0m0s
ERROR[10-26|14:19:23.093] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[10-26|14:19:23.093] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[10-26|14:19:23.094] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[10-26|14:19:23.094] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[10-26|14:19:23.094] getWhitelist invocation failed           err="Registry not deployed"
WARN [10-26|14:19:23.094] Error reading unclean shutdown markers   error="not found"
INFO [10-26|14:19:23.094] Starting peer-to-peer node               instance=ethclient.test/linux-amd64/go1.18.10
INFO [10-26|14:19:23.099] New local node record                    seq=1,698,329,963,098 id=f828ee9846ab0035 ip=127.0.0.1 udp=49717 tcp=0
INFO [10-26|14:19:23.099] Started P2P networking                   self="enode://6b9bbd2e391e3a4c317f268f515d058215d6675249480494044ab9e46c912521967b08aba9628d6a0792097df3a351211a02bff752d51a9c57a3ea1c48a67103@127.0.0.1:0?discport=49717" maxdialed=0 maxinbound=0
ERROR[10-26|14:19:23.100] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[10-26|14:19:23.100] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[10-26|14:19:23.100] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[10-26|14:19:23.100] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[10-26|14:19:23.100] Error invoking evm function: can't unpack result to=0x000000000000000000000000000000000000ce10 method=getAddressFor err="abi: attempting to unmarshall an empty string while arguments are expected" maxgas=100,000
ERROR[10-26|14:19:23.100] getWhitelist invocation failed           err="Registry not deployed"
INFO [10-26|14:19:23.100] Imported new chain segment               blocks=1 txs=0 mgas=0.000 elapsed="686.21µs" mgasps=0.000 number=1 hash=39401a..57383c age=54y7mo6d dirty=686.00B
  TestEthClient/TestTxInBlockInterrupted: ethclient
    ethclient_test.go:382: error should not be nil/notfound
INFO [10-26|14:19:23.210] Ethereum protocol stopped 
INFO [10-26|14:19:23.210] Transaction pool stopped 
INFO [10-26|14:19:23.210] Writing cached state to disk             block=1 hash=39401a..57383c root=c937d6..c7bf14
INFO [10-26|14:19:23.210] Persisted trie from memory database      nodes=3 size=398.00B time="88.676µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=0.00B
INFO [10-26|14:19:23.210] Blockchain stopped 
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.
codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a59dd19) 55.09% compared to head (f8dc509) 55.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2200 +/- ## ========================================== - Coverage 55.09% 55.05% -0.04% ========================================== Files 682 682 Lines 114447 114447 ========================================== - Hits 63049 63012 -37 - Misses 47509 47543 +34 - Partials 3889 3892 +3 ``` [see 31 files with indirect coverage changes](https://app.codecov.io/gh/celo-org/celo-blockchain/pull/2200/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.