celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
554 stars 199 forks source link

Using glibc for amd64 and muslc for arm64 #2213

Closed jcortejoso closed 8 months ago

jcortejoso commented 8 months ago

Description

As pointed by @carterqw2 (🙏 ), celo-bls-go is not compatible with musl for amd64.

This PR aims to use glibc for amd64 image, and musl for arm64 images.

github-actions[bot] commented 8 months ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 3a189b0d90c918e817f82230a37eb5605553c4c2

coverage: 50.7% of statements across all listed packages
coverage:  63.2% of statements in consensus/istanbul
coverage:  42.7% of statements in consensus/istanbul/announce
coverage:  55.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  64.7% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.2% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 8 months ago
5881 passed, 45 skipped
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (44c7490) 55.09% compared to head (44e4e06) 55.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2213 +/- ## ========================================== + Coverage 55.09% 55.12% +0.03% ========================================== Files 683 683 Lines 114533 114533 ========================================== + Hits 63100 63137 +37 + Misses 47541 47502 -39 - Partials 3892 3894 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.