search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
554 stars 199 forks source link

Update container CI #2218

Closed jcortejoso closed 7 months ago

jcortejoso commented 7 months ago

Description

This PR include two changes to container CI workflows:

  1. Remove the build-sign-binaries.yaml workflow: This workflow/release relied on xgo compilation, that relied on removed dependencies (https://github.com/karalabe/xgo). This release would be needed for Android/iOS releases, but as longer as it is not supported by upstream go-ethereum right now, we'd need to figure out and replace dependencies to build it again. Removing the workflow until we work on this refactor.

  2. Update the container CI workflow version, and enable trivy scan so CVE reports are available under the security tab.

github-advanced-security[bot] commented 7 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-actions[bot] commented 7 months ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 346c5b3f771fc7cb2f58fdb1a702e86b76c174cf

coverage: 49.8% of statements across all listed packages 
coverage:  63.4% of statements in consensus/istanbul
coverage:  42.9% of statements in consensus/istanbul/announce
coverage:  55.8% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  61.1% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.2% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 7 months ago

5880 passed, 1 failed, 45 skipped

Test failures:
  TestEthersJSCompatibilityDisableAfterGingerbread: e2e_test

Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000  denominator = 1000000000000000000000000 
Checking gas price minimum. cusdValue = 100000000
Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000  denominator = 1000000000000000000000000 
Checking gas price minimum. cusdValue = 100000000
    e2e_test.go:742: 
    e2e_test.go:744:
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.