github-actions[bot]
commented
7 months ago Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 0a9662f1c1d24918858ce4aa65acbef87dd0e05a
coverage: 50.6% of statements across all listed packages
coverage: 63.4% of statements in consensus/istanbul coverage: 42.7% of statements in consensus/istanbul/announce coverage: 55.8% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 64.2% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random
codecov[bot]
Note that this duplicates #2216 because we force reverted master after #2216 was merged.
Description
Ensures that for mainnet, alfajores and baklava, nodes will return the correct block gas limit up to the gingerbread fork even if they are not archive nodes when running in eth compatibility mode (I.E.
--disablerpcethcompatibilityis not set). More detail can be found here:2214
Other changes
A small re-factor of GetBlockByNumber and GetBlockByHash to reduce the depth of nesting.
Tested
CI is passing
Related issues
Backwards compatibility
This change is not backwards compatible with the previous implementations on mainnet, alfajores or baklava which would have returned a zero gas limit for a block if there was no state for that block.