Closed hbandura closed 7 months ago
Coverage from tests in ./e2e_test/...
for ./consensus/istanbul/...
at commit 8f49d7e7b6da5ef44722ad5119dc2c2c3d8a140a
coverage: 63.2% of statements in consensus/istanbul coverage: 42.7% of statements in consensus/istanbul/announce coverage: 55.7% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 61.2% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random
Attention: 23 lines
in your changes are missing coverage. Please review.
Comparison is base (
69dbdae
) 55.10% compared to head (9bfde3e
) 55.08%. Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
eth/api_backend.go | 0.00% | 8 Missing :warning: |
les/api_backend.go | 0.00% | 8 Missing :warning: |
core/types/celo_additions.go | 0.00% | 5 Missing :warning: |
contracts/currency/currency.go | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@hbandura this failure TestEthersJSCompatibility: e2e_test
is fixed by my pr #2229 , not sure about the other two failures though
@hbandura this failure
TestEthersJSCompatibility: e2e_test
is fixed by my pr #2229 , not sure about the other two failures though
Hey @hbandura I started looking into those other failing tests, because they were failing for me and it seems that they are also failing for similar reasons to TestEthersJSCompatibility
basically a lack of gingerbread fields on the genesis block. I'm working on a PR to fix all these gingerbread genesis issues and once that is done it should solve your problems here.
@hbandura #2245 has been merged and I think will fix all the flaky tests you are encountering on this PR!
Fix the underpriced check by checking against all currency heaps